From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751891AbcF0C2W (ORCPT ); Sun, 26 Jun 2016 22:28:22 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:60885 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbcF0C2U (ORCPT ); Sun, 26 Jun 2016 22:28:20 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79876d000001436-22-57708f427a31 Content-transfer-encoding: 8BIT Message-id: <57708F41.6010201@samsung.com> Date: Mon, 27 Jun 2016 11:28:17 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Paul Gortmaker , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Kyungmin Park , linux-pm@vger.kernel.org Subject: Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular References: <20160625184351.5045-1-paul.gortmaker@windriver.com> <20160625184351.5045-3-paul.gortmaker@windriver.com> In-reply-to: <20160625184351.5045-3-paul.gortmaker@windriver.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42JZI2JSoOvUXxBu0HhX0OJs0xt2i8u75rBZ fO49wmhxu3EFm8W1vceZHVg9+rasYvT4vEnOY/2WrUwBzFFcNimpOZllqUX6dglcGb+m7Gcu eM1Z8W7vXpYGxj/sXYycHBICJhLLvr6CssUkLtxbzwZiCwmsYJRobkmHqXn+aANzFyMXUHwW o8SdP8uZQBK8AoISPybfY+li5OBgFpCXOHIpGyTMLKAuMWneIqj6B4wSEx6cZ4So15KYvOAt WC+LgKrE9ecbwWw2oPj+FzfYQOaICkRIdJ+oBAmLCPhLbN+whh1iZpHE1e33wcqFBQIkFtxb xw4x/zSjxNz/88CKOAUcJa7MPskMcfQ2domtr4UgdglIfJt8COxOCQFZiU0HoEokJQ6uuMEy gVFsFpJvZiF8MwvJNwsYmVcxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn525iBEbS6X/Pencw3j5g fYhRgINRiYdXQ74gXIg1say4MvcQoynQEROZpUST84HxmlcSb2hsZmRhamJqbGRuaaYkzqso 9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA2NIq15eL//Wa7bTVDU+V2j9nVjq4bVfx0j9 RUnM04A/LTNP7TssF+e1gvO6242mnHMeeRt+L5kpfWNV/df+H6bG3KfizZxqZhxtSDt3qm11 wyF9L3a+5R6972w33VdYmMBYxuS8UeZb5mKl7iDevTX5/iln70wJTlXK+9TLJlgdJLvlw53P 35VYijMSDbWYi4oTATIUrVyfAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsVy+t9jQV2n/oJwg+m/eCzONr1ht7i8aw6b xefeI4wWtxtXsFlc23uc2YHVo2/LKkaPz5vkPNZv2coUwBzVwGiTkZqYklqkkJqXnJ+SmZdu q+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RTSaEsMacUKBSQWFyspG+HaUJoiJuu BUxjhK5vSBBcj5EBGkhYw5jxa8p+5oLXnBXv9u5laWD8w97FyMkhIWAi8fzRBmYIW0ziwr31 bF2MXBxCArMYJe78Wc4EkuAVEJT4MfkeSxcjBwezgLzEkUvZIGFmAXWJSfMWMUPUP2CUmPDg PCNEvZbE5AVvwXpZBFQlrj/fCGazAcX3v7jBBjJHVCBCovtEJUhYRMBfYvuGNewQM4skrm6/ D1YuLBAgseDeOnaI+acZJeb+nwdWxCngKHFl9knmCYxAVyKcNwvhvFlIzlvAyLyKUSK1ILmg OCk91ygvtVyvODG3uDQvXS85P3cTIzhin0nvYDy8y/0QowAHoxIPr4Z8QbgQa2JZcWXuIUYJ DmYlEV61bqAQb0piZVVqUX58UWlOavEhRlOg/yYyS4km5wOTSV5JvKGxiZmRpZG5oYWRsbmS OO/j/+vChATSE0tSs1NTC1KLYPqYODilGhjd4ibHCp3X5jvnlHogJfny+o93Tky+qLoj6IAO V7apVXD2oqN3uWfWza/7orXB4yBvc57ko4Rgp5LurrlB4c6OSy4qbjy5yybtRSvb702nwubv 25b3jrUp2Pdm/lqrc9NnlNrw31q30g8Y2ybP99nd4Z70+NibnNulx+Ws2DSnxLDLJWU4qyqx FGckGmoxFxUnAgDl99TS7gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 2016년 06월 26일 03:43, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > menuconfig PM_DEVFREQ_EVENT > bool "DEVFREQ-Event device Support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > This code wasn't using module_init, so we don't need to be concerned > with altering the initcall level here. > > We don't replace module.h with init.h since the file already has that. > But we do add export.h since this file does export some symbols. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: MyungJoo Ham > Cc: Kyungmin Park > Cc: Chanwoo Choi > Cc: linux-pm@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/devfreq/devfreq-event.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) Acked-by: Chanwoo Choi Regards, Chanwoo Choi