From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbcF0Kiq (ORCPT ); Mon, 27 Jun 2016 06:38:46 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:51249 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbcF0Kip (ORCPT ); Mon, 27 Jun 2016 06:38:45 -0400 Subject: Re: powerpc/fadump: trivial fix of spelling mistake, clean up message To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Kosina , Rasmus Villemoes , Andrew Morton , linuxppc-dev@lists.ozlabs.org References: <3rcf3g63Wnz9s5Q@ozlabs.org> Cc: linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <5771021E.3050305@canonical.com> Date: Mon, 27 Jun 2016 11:38:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <3rcf3g63Wnz9s5Q@ozlabs.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/16 05:19, Michael Ellerman wrote: > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: >> From: Colin Ian King >> >> trivial fix to spelling mistake "rgistration" and minor clean up >> of the printk error message > > Can you also: > - use pr_err() > - unsplit the message, ie. keep the string all on one line. I can unsplit the string, but checkpatch will complain about that, so I'm not sure if that's preferred or not. WARNING: line over 80 characters Colin