From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbcF1ItW (ORCPT ); Tue, 28 Jun 2016 04:49:22 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:60605 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbcF1ItT (ORCPT ); Tue, 28 Jun 2016 04:49:19 -0400 X-AuditID: cbfec7f5-f792a6d000001302-ea-57723a09c87b Subject: Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 To: Herbert Xu References: <1467098587-1038-1-git-send-email-k.kozlowski@samsung.com> <1467098587-1038-2-git-send-email-k.kozlowski@samsung.com> <20160628084138.GD15985@gondor.apana.org.au> Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <57723A08.1010704@samsung.com> Date: Tue, 28 Jun 2016 10:49:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160628084138.GD15985@gondor.apana.org.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t/xy7qcVkXhBtvvG1tsnLGe1WLO+RYW i+5XMhavXxha3L/3k8ni8q45bA5sHltW3mTy2HZA1aNvyypGj8+b5AJYorhsUlJzMstSi/Tt Ergypqw5yVTQy1nxcsl5tgbGzexdjJwcEgImEleWdjND2GISF+6tZ+ti5OIQEljKKHFm7Rom COcZo0T/apAqDg5hgTCJwz/1QRpEBHQkVr5czApiCwlsYpQ4ckIXpJ5ZYCGjxK5Fy8ASbALG EpuXL2EDsXkFtCQe9jxkB5nDIqAq8eefOUhYVCBCYtb2H0wQJYISPybfYwGxOQUsJc59/wG2 lllAT+L+RS2QMLOAvMTmNW+ZJzAKzELSMQuhahaSqgWMzKsYRVNLkwuKk9JzjfSKE3OLS/PS 9ZLzczcxQsL46w7GpcesDjEKcDAq8fDuqCsMF2JNLCuuzD3EKMHBrCTC62dRFC7Em5JYWZVa lB9fVJqTWnyIUZqDRUmcd+au9yFCAumJJanZqakFqUUwWSYOTqkGxovcFd3pBr7XHY8suP7K kI9DXeDNdstHKnf2PhbjMZv2w8v+wseFwfu1XqtrvFb/cOYUt8tdN23luNLK0n17WWb1fdF6 79nm86X7NHeQ3AS91AP9LTtNWW5sicu6fpF3x9Q3k6b0FBU1uV8QPDpbaa3MibePol7N8mlr aKpuWRamFLdx/6SgJCWW4oxEQy3mouJEAPNa745fAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/28/2016 10:41 AM, Herbert Xu wrote: > On Tue, Jun 28, 2016 at 09:23:07AM +0200, Krzysztof Kozlowski wrote: >> gcc 4.7.3 for ARM on Ubuntu couldn't link tcrypt module because of >> division of s64: >> ERROR: "__aeabi_ldivmod" [crypto/tcrypt.ko] undefined! >> >> Fixes: 087bcd225c56 ("crypto: tcrypt - Add speed tests for SHA multibuffer algorithms") >> Signed-off-by: Krzysztof Kozlowski > > I'd prefer to be consistent here and just use unsigned long like > every other speed test in tcrypt. This code has some serious > issues, such as not waiting for completion in case of an error. > > Let me try to fix them up. > > Thanks! > > ---8<--- > Subject: crypto: tcrypt - Use unsigned long for mb ahash cycle counter > > For the timescales we are working against there is no need to > go beyond unsigned long. > > Signed-off-by: Herbert Xu > Works fine for me: Reported-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof