From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbcF2I2z (ORCPT ); Wed, 29 Jun 2016 04:28:55 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:55438 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbcF2I2N (ORCPT ); Wed, 29 Jun 2016 04:28:13 -0400 X-AuditID: cbfec7f4-f796c6d000001486-8f-57738699ed30 Subject: Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test To: Herbert Xu References: <1467098587-1038-1-git-send-email-k.kozlowski@samsung.com> <1467098587-1038-2-git-send-email-k.kozlowski@samsung.com> <20160628084138.GD15985@gondor.apana.org.au> <57723A08.1010704@samsung.com> <20160628095511.GA16644@gondor.apana.org.au> <20160628123352.GA17844@gondor.apana.org.au> <577383CA.1040204@samsung.com> <20160629081905.GA25215@gondor.apana.org.au> Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Megha Dey , Fenghua Yu , Tim Chen From: Krzysztof Kozlowski Message-id: <57738697.1050401@samsung.com> Date: Wed, 29 Jun 2016 10:28:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160629081905.GA25215@gondor.apana.org.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t/xK7oz24rDDf7vVbHYOGM9q8Wc8y0s Fm3THC26X8lYvH5haHH/3k8mi8u75rBZnH/xh8Xi2qT5bA6cHltW3mTy2HZA1WPxnpdMHvNO Bnr0bVnF6PF5k1wAWxSXTUpqTmZZapG+XQJXxqOlO1kLPjJXNC1/xt7A2M7cxcjJISFgIvGl dQ2ULSZx4d56ti5GLg4hgaWMEitap7FDOM8YJU6e6mIEqRIWSJLY9GMGWIeIgI7EypeLWSGK jjBLzFv7FqydWWAak8TVSRtZQarYBIwlNi9fwgZi8wpoSSzf/R2sm0VAVWI+0E0gtqhAhMSs 7T+YIGoEJX5MvscCYnMKWEpsf9oBFOcAGqoncf+iFkiYWUBeYvOat8wTGAVmIemYhVA1C0nV AkbmVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxghof9lB+PiY1aHGAU4GJV4eDUOFYULsSaW FVfmHmKU4GBWEuFd2FgcLsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWp RTBZJg5OqQZG/rCH11Y6G9U9MZmkz2cy66LTngP3e6RYkgvE/oqJL3GL8d/sxMrS/VYi9FXX H/1Ac9nyuZkva187rTc7s/zHK/W8lTeFLRvi+79u5pmiwSap+TMg1KzsoLjJVL9NkzmeL3/n lCIRH9bm94F5Oiezf+XJU8wSreeW5CgEdXasb5dp9NjRF6DEUpyRaKjFXFScCABk79n8eQIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2016 10:19 AM, Herbert Xu wrote: > On Wed, Jun 29, 2016 at 10:16:10AM +0200, Krzysztof Kozlowski wrote: >> >> Seems to work fine except: >> 1. The updates are always 1. > > Yes the test function only does digest so it's always one update. > >> 2. For bigger blocks it reports always 1 or 3 cycles per byte: > > Yes the average cycles per-byte should reach an asymptotic value. Then: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof