From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752964AbcF2PeK (ORCPT ); Wed, 29 Jun 2016 11:34:10 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:50749 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbcF2PeI convert rfc822-to-8bit (ORCPT ); Wed, 29 Jun 2016 11:34:08 -0400 Message-Id: <5774068C02000078000F9DCB@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Wed, 29 Jun 2016 09:34:04 -0600 From: "Jan Beulich" To: "Amitoj Kaur Chawla" Cc: , , , , , , , "Juergen Gross" , , Subject: Re: [Xen-devel] [PATCH] x86/xen: Use DIV_ROUND_UP References: <20160629150038.GA13956@amitoj-Inspiron-3542> In-Reply-To: <20160629150038.GA13956@amitoj-Inspiron-3542> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 29.06.16 at 17:00, wrote: > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -591,7 +591,7 @@ static void xen_load_gdt(const struct desc_ptr *dtr) > { > unsigned long va = dtr->address; > unsigned int size = dtr->size + 1; > - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE; > + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE); > unsigned long frames[pages]; > int f; > > @@ -640,7 +640,7 @@ static void __init xen_load_gdt_boot(const struct desc_ptr *dtr) > { > unsigned long va = dtr->address; > unsigned int size = dtr->size + 1; > - unsigned pages = (size + PAGE_SIZE - 1) / PAGE_SIZE; > + unsigned pages = DIV_ROUND_UP(size, PAGE_SIZE); > unsigned long frames[pages]; > int f; > Perhaps even more readable would be PFN_DOWN()? Jan