From: Tero Kristo <t-kristo@ti.com>
To: Bin Liu <b-liu@ti.com>, <linux-crypto@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: omap-sham - increase cra_proirity to 400
Date: Thu, 30 Jun 2016 10:24:29 +0300 [thread overview]
Message-ID: <5774C92D.5040500@ti.com> (raw)
In-Reply-To: <1467216696-8014-1-git-send-email-b-liu@ti.com>
On 29/06/16 19:11, Bin Liu wrote:
> Some software alg has cra_priority as higher as 300, so increase
> omap-sham priority to 400 to ensure it is on top of any software alg.
You could mention the case where this is causing issues, namely the
arm-neon-sha implementations which currently have priority of 150...300.
-Tero
>
> Signed-off-by: Bin Liu <b-liu@ti.com>
> ---
> drivers/crypto/omap-sham.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
> index 63464e8..aa7be252 100644
> --- a/drivers/crypto/omap-sham.c
> +++ b/drivers/crypto/omap-sham.c
> @@ -1328,7 +1328,7 @@ static struct ahash_alg algs_sha1_md5[] = {
> .halg.base = {
> .cra_name = "sha1",
> .cra_driver_name = "omap-sha1",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_KERN_DRIVER_ONLY |
> CRYPTO_ALG_ASYNC |
> @@ -1351,7 +1351,7 @@ static struct ahash_alg algs_sha1_md5[] = {
> .halg.base = {
> .cra_name = "md5",
> .cra_driver_name = "omap-md5",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_KERN_DRIVER_ONLY |
> CRYPTO_ALG_ASYNC |
> @@ -1375,7 +1375,7 @@ static struct ahash_alg algs_sha1_md5[] = {
> .halg.base = {
> .cra_name = "hmac(sha1)",
> .cra_driver_name = "omap-hmac-sha1",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_KERN_DRIVER_ONLY |
> CRYPTO_ALG_ASYNC |
> @@ -1400,7 +1400,7 @@ static struct ahash_alg algs_sha1_md5[] = {
> .halg.base = {
> .cra_name = "hmac(md5)",
> .cra_driver_name = "omap-hmac-md5",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_KERN_DRIVER_ONLY |
> CRYPTO_ALG_ASYNC |
> @@ -1428,7 +1428,7 @@ static struct ahash_alg algs_sha224_sha256[] = {
> .halg.base = {
> .cra_name = "sha224",
> .cra_driver_name = "omap-sha224",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
> @@ -1450,7 +1450,7 @@ static struct ahash_alg algs_sha224_sha256[] = {
> .halg.base = {
> .cra_name = "sha256",
> .cra_driver_name = "omap-sha256",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
> @@ -1473,7 +1473,7 @@ static struct ahash_alg algs_sha224_sha256[] = {
> .halg.base = {
> .cra_name = "hmac(sha224)",
> .cra_driver_name = "omap-hmac-sha224",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
> @@ -1497,7 +1497,7 @@ static struct ahash_alg algs_sha224_sha256[] = {
> .halg.base = {
> .cra_name = "hmac(sha256)",
> .cra_driver_name = "omap-hmac-sha256",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
> @@ -1523,7 +1523,7 @@ static struct ahash_alg algs_sha384_sha512[] = {
> .halg.base = {
> .cra_name = "sha384",
> .cra_driver_name = "omap-sha384",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
> @@ -1545,7 +1545,7 @@ static struct ahash_alg algs_sha384_sha512[] = {
> .halg.base = {
> .cra_name = "sha512",
> .cra_driver_name = "omap-sha512",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
> @@ -1568,7 +1568,7 @@ static struct ahash_alg algs_sha384_sha512[] = {
> .halg.base = {
> .cra_name = "hmac(sha384)",
> .cra_driver_name = "omap-hmac-sha384",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
> @@ -1592,7 +1592,7 @@ static struct ahash_alg algs_sha384_sha512[] = {
> .halg.base = {
> .cra_name = "hmac(sha512)",
> .cra_driver_name = "omap-hmac-sha512",
> - .cra_priority = 100,
> + .cra_priority = 400,
> .cra_flags = CRYPTO_ALG_TYPE_AHASH |
> CRYPTO_ALG_ASYNC |
> CRYPTO_ALG_NEED_FALLBACK,
>
next prev parent reply other threads:[~2016-06-30 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 16:11 Bin Liu
2016-06-30 7:24 ` Tero Kristo [this message]
2016-06-30 19:04 ` [PATCH v2] " Bin Liu
2016-07-03 2:47 ` [PATCH] " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5774C92D.5040500@ti.com \
--to=t-kristo@ti.com \
--cc=b-liu@ti.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome