From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbcF3JGO (ORCPT ); Thu, 30 Jun 2016 05:06:14 -0400 Received: from mx-rz-1.rrze.uni-erlangen.de ([131.188.11.20]:58856 "EHLO mx-rz-1.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbcF3JGM (ORCPT ); Thu, 30 Jun 2016 05:06:12 -0400 X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 2001:638:a000:4142::ff10:d304 To: "Naveen N. Rao" Cc: Michael Ellerman , "linux-kernel@vger.kernel.org" , linuxppc-dev@lists.ozlabs.org From: Andreas Ziegler Subject: Re: [PATCHv2 0/7] eBPF JIT for PPC64 X-Enigmail-Draft-Status: N1110 In-Reply-To: Message-ID: <5774E0FC.7010407@fau.de> Date: Thu, 30 Jun 2016 11:06:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naveen, this patchset makes a change to arch/powerpc/net/Makefile in order to only compile the previously existing bpf_jit_comp.c if !CONFIG_PPC64, and use bpf_jit_comp64.c if CONFIG_PPC64 is enabled. Inside arch/powerpc/net/bpf_jit_comp.c, however, there is still an #ifdef CONFIG_PPC64 block at line 667 (linux-next of today, i.e., next-20160630): #ifdef CONFIG_PPC64 /* Function descriptor nastiness: Address + TOC */ ((u64 *)image)[0] = (u64)code_base; ((u64 *)image)[1] = local_paca->kernel_toc; #endif >>From my understanding of the code, this #ifdef can now be removed, as there is no way the file could be compiled with CONFIG_PPC64 enabled. Is this correct? Best regards, Andreas