From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA8A328506B for ; Wed, 1 Oct 2025 09:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759309297; cv=none; b=X5RQbJbcPJBeMojIAo+Txn+WjEcGFzaOkDqZllOY98PEFbEcmfs19wWWY6Egvl+/jus0azE76yCBqDVPgNW2Zy7SiSeXAXJ8woxC5G2RoAL4f2jvjKQBDXvTjpJAgpxzFupaZpuCvVGmTcoQyZfKysShmiQhpBA7b5WqGi7QEDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759309297; c=relaxed/simple; bh=dlajLtcAMxSk0NrozjS9CF0M15RGimUH1gNNnAg1huI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cvzMuOMcBrab1ewlJ0BCVEyWBPaiXuQ6pxXW9qQb742xWDpftXGzIcBY7rL9hMBrGHM/HNsudA5pFLNDEEq0yES3j1Ds8r/VqtNwhjAZEqwNiO0lq0o7NC0B7Sc7JEUIusukX0fxuHV6jDwKsfG3oFfyEMX0IIhMBZ7W3ktuL7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gSs/Fhrr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gSs/Fhrr" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58ULoJYV030669 for ; Wed, 1 Oct 2025 09:01:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B42pLGH75pGjx/3inm5Dy5xji4vr0c5P39RfvM77Mi8=; b=gSs/FhrrepVTfPfO rrJQv6fw3OGskESs5DXaCijLP+v+YJwoJceHzDSVbZxNhYl8Qgx0qnt3J9BY5o0J OHRfhLiFnuPvxJTy7SurzjzFHD6/9uSlC2HdOY3CT/OyGiHkaXlnc5fhp1LeGbj/ 0hKdUlGca8b9qnR51NG0tDcpz6WuhKhWEC91YD5uik5UQbONhRiA1mMVPM7hTYaR eELunro5tlhROvAXtKQWfTX8F4P8oapwslYVqD2kaTfXhvQ+XZDQlqqI0mrFwWMB cbexr+CMuZoRe0VvYWSyp3Xkl9tEF+ULTT5Bcgmkd6pZjcruLc74PBUEYsyITJIf 5TRBmg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e8pdkpr5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 01 Oct 2025 09:01:34 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4e231785cc3so7199351cf.1 for ; Wed, 01 Oct 2025 02:01:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759309293; x=1759914093; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B42pLGH75pGjx/3inm5Dy5xji4vr0c5P39RfvM77Mi8=; b=DgrMdf2lttHObyMpJR/bUOhw4xMVX/+9mw/ASIx7ja5QUPXTXP5zX4s5hbZz0vXrqH r2YiD28KrxuCvXui8wa1Zu2pYPTAb8i5J4tgQ0L6atsZtgrw1C4IZFLoxqgp+uHjdHfl reAjrzb1M7FS6LohvLslFuM5DpzdB4j5LlIC82I2jkrJc8RXwarA+QwGxR7ybPEn/tHo 7yPtEgTkYNarYYx+JzkMaPBSrCTyrbN3/GdstvgEYuptFfPc4n2n07P1d/e+a+CSdm8D J8qHD3YLXrZW8alnoSXyHRrKN6CZifSiWkA8BtfJn7j5stUNJ+vZ0QaBVafagkbOgHf1 wlXg== X-Forwarded-Encrypted: i=1; AJvYcCWZRSXad1UCR2xzXEWJNYbyFM7g/ETAc20An+zx2DFFkeSeUG3178+tNHokDzJ3DZwp0RD8o+PxREybyhM=@vger.kernel.org X-Gm-Message-State: AOJu0YxmIGTL63s4TZhCqNdruAZmy+cZn7PHuoSsN4HIX5h4uykzzGXk V6d3yXcQu80H1TotgWTXDYFIWLlouAAumkNLGViaObtuSh8ino5GkbZ/qkL2gzTdC71bYEyllMN bnDkxEaE3v+JMGYr0zZimEZuZLj+D4GLB6ryAqhbQgaDNoPkpFFHZMQ2qdia8nfYVVQQ= X-Gm-Gg: ASbGncvVyCm9la9mCs51WB0BOiiMzlz92agJB7GmHxckXeJ8J0grcHdv80jlmSVgDnB Y27AmBgVZRJvTj6s9vdNSLAvOP3/+9oWddmI2N8K0SvGdOHnLiuWeU+2aMkWBAVQANaP9tOWdDy X2UMeqT4261gQLAOnNj7U8Eg3z0ncFF/LM/VragbHBwBMyVbs5YU8qSyYxHhNuQ3sEpN5Ggk353 RWZ+JEnVJ0C+VJCqACUFzppprSEByecb+XSLeFjDEHWoaASj74LfJtXIbevTie17HAvwsEGDkpd eQhLn2f2rBlRUWdLqvKVKAq96lI2FmrqiQPLcqJsvo/Ubi1u1Q6jhwXr1pKK/chMMIPfD4JX1jW WiGdaVz0Hf83eRd7ssUJwC9mz0R0= X-Received: by 2002:a05:622a:11c7:b0:4b7:94ee:4fb2 with SMTP id d75a77b69052e-4e41c54729amr23669161cf.5.1759309293294; Wed, 01 Oct 2025 02:01:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFghnDnhD89xfq3NpxumOgiOvGyipA7QKcNPEFFvbSfXFdc2E0wmIKiKI+YIF9fBkkm1d+LAA== X-Received: by 2002:a05:622a:11c7:b0:4b7:94ee:4fb2 with SMTP id d75a77b69052e-4e41c54729amr23668841cf.5.1759309292804; Wed, 01 Oct 2025 02:01:32 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63662dc0a3csm3035680a12.48.2025.10.01.02.01.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 02:01:32 -0700 (PDT) Message-ID: <57774099-08f1-4ede-b992-19f220bf8059@oss.qualcomm.com> Date: Wed, 1 Oct 2025 11:01:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/11] arm64: dts: qcom: sdm845-lg-common: Add leds To: Paul Sajna , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Heidelberg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Amir Dahan , Christopher Brown References: <20250928-judyln-dts-v3-0-b14cf9e9a928@postmarketos.org> <20250928-judyln-dts-v3-4-b14cf9e9a928@postmarketos.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250928-judyln-dts-v3-4-b14cf9e9a928@postmarketos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 0ryhVVJTmxYpOHv_iHgK9eCS65lc7MRD X-Authority-Analysis: v=2.4 cv=MYZhep/f c=1 sm=1 tr=0 ts=68dcedee cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=sfOm8-O8AAAA:8 a=Gbw9aFdXAAAA:8 a=kAMZL_UcEcdRErClG6YA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=TvTJqdcANYtsRzA46cdi:22 a=9vIz8raoGPyDa4jBFAYH:22 X-Proofpoint-ORIG-GUID: 0ryhVVJTmxYpOHv_iHgK9eCS65lc7MRD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAzNiBTYWx0ZWRfXxnnpbfzQOJmK XATDLpAKiwrXRLCAZmglGXTH2jsEhpRH9WxDdXZVbaUh2uJq6AmM35x+pOMNN7BqmKQ2L0E3/r6 LIp6LHb//gs5XyA60hT6L5UuJ5lrRXvNyJCJY+cLBEhLKn4l/5TcosgDuyzHrKrKYf/zOPcjQ1T JLKc4hEYAmGRquMUvYjd0GvPDfIzGH+LG0Yf8+iy/uN+nf1/FMHdlE+CjCyZulL/PMW6CfRZiCQ Otipgppbp3+T1alNy/nhBhhberhl4lv9scA2hbGOFcJ/BzNwdlNGgQm7Fy+cyGtBkupXGoe1ymP 7veWQt0CtS/pppplaShnDx1KN1jLi9uciIRbT7Tuf3S0lGXie4nwzeuLXm+6hii9/GJeBhtZTu/ ZRq1QnTr/On7jpYM1I588c+M/1iacw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-01_02,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270036 On 9/29/25 7:05 AM, Paul Sajna wrote: > From: Amir Dahan > > Add the multicolor status led in the phone's notch > > Signed-off-by: Amir Dahan > Signed-off-by: Paul Sajna > --- > arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 28 ++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > index 4c631df56f262ba9e730f6720abd94d374b14692..2a612922ecf7ce3f8a0734cb1a31a8a81efdb4f2 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > #include > > @@ -504,6 +505,33 @@ &pm8998_resin { > status = "okay"; > }; > > +&pmi8998_lpg { > + status = "okay"; Could you read back register 0xd000+0x45 (LED_SRC_SEL) on downstream and make sure the value matches upstream? A msm8998 kernel fork I have laying around on my computer always seems to write '1' in there (which it claims corresponds to VPH_PWR as input) Konrad