From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbdA0GYJ (ORCPT ); Fri, 27 Jan 2017 01:24:09 -0500 Received: from mail-cys01nam02on0044.outbound.protection.outlook.com ([104.47.37.44]:53792 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753841AbdA0GYH (ORCPT ); Fri, 27 Jan 2017 01:24:07 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=thellstrom@vmware.com; Subject: Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable To: =?UTF-8?Q?Michel_D=c3=a4nzer?= , Sinclair Yeh , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20170125082131.25544-1-michel@daenzer.net> <56e0a49e-89b6-4542-e905-57f0dc2ae79c@amd.com> <20170126004632.GA3457@vmware.com> <9af4b5b5-a8a5-8908-f59f-6cdc8efe0570@daenzer.net> CC: , , Daniel Vetter From: Thomas Hellstrom Message-ID: <5778f881-ce81-1c58-f2d4-02175c3d2615@vmware.com> Date: Fri, 27 Jan 2017 07:23:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <9af4b5b5-a8a5-8908-f59f-6cdc8efe0570@daenzer.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [155.4.205.56] X-ClientProxiedBy: BN6PR16CA0005.namprd16.prod.outlook.com (10.172.212.143) To SN1PR05MB2336.namprd05.prod.outlook.com (10.169.125.26) X-MS-Office365-Filtering-Correlation-Id: 865937ce-836c-4e61-f31b-08d4467d17ea X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR05MB2336; X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB2336;3:ffrfUm8PSrWoWY9yGskNy2FhP4WlgQ8lJr3ovnc09TuFz60YSArkwoVQY/flnZmqQQCmUhoZaxOjQS5yXZkHkrydef2nq5EZzRy9bJLJ+/OiEdBFt02oJGugtV8zkTcVXiA/Z/RNurSiAsiOgAmPvkfqhTnsD8e0jzwkXccM5zIjvPs/R3lmyG7FBA6EBB5AJz6cqNeV4BSGXUNeBbNOWeBmX40zk9hk+VM2SYwhwiWMTfH4mQHvCvBzJyQHwfWcKWCJK/812seOSlaiuW/g1w==;25:wiaupx63rSNIkAsJVyE2YJx6B/kA79Ze7EP4o+eUYkU8gNvjfy3XDQeldxuVtyu8Hqz8nTiwJs8GVpGzWuDrLD2H4FgNJ1leAqDyLA2fqH6FmDOd8Qf7TGyuWHKQeVAzKE4hX3AvunJtgz3WHRTiCnz09NBxgfcBY6EnZyPc+l6vo9DXKUKhe91/G9Q0GtvpilTijWM4/n0H96TMgF1sQSPVmGksN/pqRkjTBPTIG7aYUTV9law/bCSkMS/o18UPmgmTPa/pxBKxlcYI/PLJOBelPgoT2YaBWRUzMULYOkxmGLV8uk/rlD25K6a2QHel4+xfs/Vg1EBUQM20cMegookSIlv4EdJ7xE7ccZ55gUPL1JTJGv9/MVxaFNbp5ShUA/G/WbdUwhNVIg33ljpWxcQBDPnaVFl3Yy4F9RlHWBjgsSqwYQo5yapx5I9F06vqpkqEQM+woYk+iAvW0cWEEg== X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB2336;31:GR8XUoA3eIA3RkxV+WchMtqlEf8ahFwGAfsKPy32K84EcRWXno3S1ihlOJBjdIPUp9EOLivN7u77+CMKtrqNJdiagMdTKhDerfh8zuYMclGRlOtK6voiX0RawvQkk0SsRtTXXMJKig0PBVRBqxmvuawjvYU1dCfiRav80GbcnZc6uzoHuAXAzgajVIj3LHAuSEocdMvkP9UrnFRa9yDocilfBlC8AqeZx2kmoiuz0yoCpgCcLFs6DMLsjS50/8yX;20:fh7tLQ55N4GkyuAkxUKMNGqDhsvkmPIHXNcv88kDMiC8pL6HZWOJzvSO89Eday+gUgvop2/DlC0ccpyk7wa9XT5JgDN5LlqvDyBaXKUSBdyv5UxZPUPanh72cbsBJy7TP/S0ZisPQkvHi2+OjcAhrNhSurvXbxm6HNcdB8tGPd6UaH97kUEN3NRqOk1+rYPZzfkyZI3UH/p9ZB8HZngCb3bf83bAUySwJVFfJyGimmu+ZwG5KOxa9R9O2tMqAVWgfYgLoxuxTMEPMMlA/omuxi1BZqQHcFBt5fJOvPPPBYLm1xQD/UfQSQdQmCLKHdKb9TBxU5rbKhhqIYZirmBaadCYeq9SBqUXd2wylflFgUYe8fDqAl5Ohz35IbGfVVlNaGQ37Idj9ASoJ100xexpoZPWbIAFpxgoUivRnowSR1bezwbUeRDK81Galp0ywYVcKD3tXj4c0EzFyFyYGuDSiIxUPnPlt6ohF1RXupeBfFoSSJ7d3VzFC/TG+d5ImuES X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(9452136761055)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(6072148);SRVR:SN1PR05MB2336;BCL:0;PCL:0;RULEID:;SRVR:SN1PR05MB2336; X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB2336;4:fNd6pf9K1Ca4ldLTV6Kwe8WyUJTVVWXTj9zCKeqizl/M/AyHTKRj+PFeeoGWz95L48E8b6whaZeWLH1M7gIeyD8GM7nx0RuvWljy3RzJAaTs2AjxvlKTpwwSY2dMkjj9jxcQlmmPMZMvG3gQ73mGdbSYexyWBItdcDkxZSEN32sA4/HFMGbBp97GVWCL8pt/auI1xOyDl3zQSJ3ZJBZcTwlbRmtXiFj+3cCFKQo6HvOG+oNjV/75egoilDb+XipXLO84gvAtsy2vtIkHorxyGCI9f9wF4ACBwRJyZFYjPQg8/LtTDAbok0V2pwZ3w99yH5ISUzKT7SYfknRmD6rg5olh78o+3UTsub9LH1OXpqWBSVa37ZF5HUHKvU8tNWzprWKDUGNR7KeRYVLkrzplAWMlxHXIodRjN8lAZ4FP18wj14L91H3ZCQ+6e3rd0nsK0FjeDQfD8tdE7oDfZZK2oxTvzLc8eg2yXiTOpAg1Nv5cQ8awxgIMs/49frBeUiK1RZUaW0/vdb32Jc4z0iuMa2rsVhhOnhyqICOG2JJ0zEDN/HTcX+UzwCeJP5d879FxxdAhr91Hd/pg6p8xr6f2YiP9LnDCEnWfZA9w2WgmNuG11yAb1Jwzmiufi/nBH0dzjAy2HueDkrRPstiUZ9BnW6tGfQ8/GfHu4Nu4xLhoDfaKtR9aPyxt4T//kLPx0Hqt X-Forefront-PRVS: 0200DDA8BE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(51914003)(377454003)(199003)(24454002)(54906002)(33646002)(42186005)(31686004)(76176999)(101416001)(66066001)(4001350100001)(54356999)(65956001)(65806001)(23676002)(105586002)(106356001)(50986999)(25786008)(8666007)(38730400001)(6486002)(6506006)(5001770100001)(92566002)(50466002)(97736004)(64126003)(47776003)(229853002)(6512007)(93886004)(189998001)(65826007)(8676002)(83506001)(31696002)(2906002)(36756003)(5660300001)(68736007)(4326007)(86362001)(53936002)(2870700001)(6666003)(2950100002)(6116002)(81166006)(7736002)(81156014)(3846002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR05MB2336;H:linlap1.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjA1TUIyMzM2OzIzOnU3d3FBemZsMzB0dUM4ckNzdVFydUc5aHc4?= =?utf-8?B?U3dmS1NtVnJxaExpdHhaMHN2bGcrcW5OOUNubGkxUzIvMlVCYy9iK1JPaGtR?= =?utf-8?B?dm81ZFdqTzY3a0tnVU54VjN5T0YrbTM5ZVNqbFJVV0JRaDhyVmdKTEduZVVL?= =?utf-8?B?T1lRRitKMDdLMVVrbm5hNCtsSEtKRFVNcXNBbmFOWUZIRk5HYThOdExPZHpY?= =?utf-8?B?MGhmOUZnSkxkMC9JbTFDcWQyWFVtKzRkOXRuSzBtWXk1cmRNTUNSQ2htMURu?= =?utf-8?B?WDJ6RXZkSEZUNnJ0OEZnMlJoM1ZGVTdqQStpTGttQTNEMWtlK0xGMlkzdlpD?= =?utf-8?B?SUpkNlhFU2FjMDY3d0FvNy95Y2pQZm1YMVRRMGdQdVBZdWE1MWhuSmFsOXlR?= =?utf-8?B?WGJERVlTWDZ0NjlBcnJtczBINWRvMnVWQk1BWWJqbUU2cGw5RUQ4ZEw2dTFX?= =?utf-8?B?ZWtNd1BvM1VrTXpiQmZwYmphcC92NWJJc1hoOWtnME5meXZWK3BKTzRnQU5p?= =?utf-8?B?VjN2bUtwa3hVUHpXZVlMNzZNVDBMNlN6cUQ5b29kZXRWdFpNVEY5NFNRc3JN?= =?utf-8?B?YjZMYWUvOHBCUm9HdUlpMkc3S3hPd2pjQWo1M0tvSmcvN2liay9TV3ZyVi9J?= =?utf-8?B?R2ZzMUMzd21wdG9BdzU2WExRVHRWbG16VWxLYmovUzJQNllienFVQksrMnph?= =?utf-8?B?c3dvanhGWVU2eUE5WTRReDIwYWltejhzWlZFZTFIR2hPNXVjblJQbUtlbnpV?= =?utf-8?B?dEhoSFBGUDcvelBsYU5haXBNVXNIK3ZKYjRobzNMYm12TkkrN0RWbzArWE5s?= =?utf-8?B?NmEwUmpJeTlBcUJ1ZFlwVUhWQkdRVHIzWkFuYWxNMkp2TVNKNitZOG9yeEJX?= =?utf-8?B?emNzU0lWTEkzOE9qbzg2Z1pwOURuM0tCQVdCUWJIczhvWXA4R1R0eGdDRjA5?= =?utf-8?B?N1pRTXYwc0hDNFJxb2NrNldLRjMzVWZLaWZwZjZ2NFdSNWFYQmdkV1NzMTdU?= =?utf-8?B?aXdmb1VFWDBoRGR5QXA0NUpaNDMyRmg2M2hETkl1WHd3SjNCYS9DYkdQR0NK?= =?utf-8?B?dmNmUFpEcloxRUZzS1hzOUFiaExXRnY5TjNTTFIxd3JQSDg0L0J1LzNoa3Q0?= =?utf-8?B?dFIvWnhCRDQ1RCtrVXZTQWgycERXUlpSaU1VUzJSaXNRMFhEc1JCb05CMFlh?= =?utf-8?B?SkxjaXlLbHZlaGZNYWJFbHBGSnBMYnU2ODR5S05vb3drZHhUMnBCcS9uaXhx?= =?utf-8?B?U2loZHh2VUxkMXlYclFBODJiN1FlbHF1cTlzOHVmYWd0OElqOTJCZ0xKWE0x?= =?utf-8?B?a1lGRWRkTU9rdGt0THBVcUNNVER3eDNIOUxtV2YvdmdyU28vU1h3ajZYOTRy?= =?utf-8?B?ZXY1S2dnWkM4OVl2d3piYS95TGR3UzIxakpMb3kvdlpUZWt2cjkzZStJalEv?= =?utf-8?B?OENhZjZHbzZnbEZOSmhRODdqRERVSEpEOEVwRFZKNURXb0ZhK29oeUtxV2VS?= =?utf-8?B?alZCNmlnN0lKVnhrcjVib2JaSmdVa1dLM05Uc2VFM3ExRjR4NUI1ZGNEdmlZ?= =?utf-8?B?cHlackk5blJldkYrSGRudm5ZamhZZVJXNTI4eGIybGRVZGlSVW1SV1BrMmtl?= =?utf-8?B?UXlXZlBBMzVYMTNrS2Z4NUV0M1JvdE9rVStVZDk0aVppNFFCOW10UlhidW5J?= =?utf-8?B?M1hSNHNNLy9EZWxrdTZuVUVTWlpwdzkycTU5Y3ZuWjUrdnAySFVycmp0cjdX?= =?utf-8?B?NmNEUEZaV2dCOEYrMjZGOW85SG5qdncrSWoxQk1Jc1NDQUkwckRSOHJkN0ZD?= =?utf-8?B?a1owYWZoOEk3Z0JDTWlRYlNzN3N1elY4MTM3enV5SVlLcG5zQldtZkZrNzJr?= =?utf-8?B?ckJjcDBINGF0T0Q3ckF2STZNUFJEVzQwQk1XRnJIUXNLZGNqRWhGWUFmZC92?= =?utf-8?B?b3VnRElvK0J3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB2336;6:XykWtD5UfhTCzhVAAijkDHVn7+K2S75tNb3zJpgJbAxFUJo2LGJhxWOn6X8rLQCrEmMOpgRpHYeFgk0wAGT8l6HweHBbJuf6GB1Zh2OBLnrUr2SRGUKPsQtEuekottZ39f1km3Hy+XZdBFk7DuKvnECUXPx7cRPmvFS4fpuncNQeLOhx11VkGw4XxyCqiVbIQZP5+F4SpcawknO0abz87L9W42eQDJDvYaqx0H9cJC5GX68gNQpXxcV27ISTE3HelHZWbVsS/j7C3pcxLWFqYf+oEnMwTaF3mU6upl3mZGwIXLbqt5EJVKLJRiiDEwfTSlNo19O4jdkYOWz58DJ3fexw8+Hd5ASN+/oYo87uoRHRxvlOCmbw0w+Ts2tgL2r6kFMd2gKMR26YMq7K1GrzziQJk88+3jXFj3LzkvpDqcs=;5:YlSoGAQllAM9ebfI+pGOpvAPJ4UAuXQigb1mOVAG4n5NAMsLJ8SuK1vaIVd/vxbZCm1V73n85pW+v0W+4JyYt4kp/5i9qpchlH8JsG+0G/Ax2ZQzqcGVTN/m3C6CS68+N6MjMi/3kVTbiC0IKL7gRg==;24:R2mF2G+aALqDxb0LZjX4DjFw8tICW1fCkGZyaqPbw3IZSybMUyIdGTmNwA/VBk5Yxy+/mrdQGUL+zrHd7RDbcWw8orehztMi1C08RaXVdu0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR05MB2336;7:ADbBwQQP3fIPpQmnKrDesRjvc3uL3jdxYWOXFr8vlNOj9UGmBNk48QWnNF/lKfxgvTNXYnlqoKHVHPqUPgFEs3jp1bNSTcUyVbaZjp5FgMCSqAAp45aRr9SNkasw3zNXSgusLJATmQGCgZYxVbgxQrJPiOP2hLr069DUneIhAokrESPrjcOSK5b+UpqfMovPeGmD+MFw+d6OIVK6GF1PF+gmgjqScn/yQoQeSrrpekfweYNsFbp9Gl/z51LgUeErlCjqkYsmi4nb710FlvkYPI3JsxNHrDvhwrLve4my3biGO+THQ8lWouxh5fYnMpENxwNail19tyijbGQTyFHhfTjzvpWQRq8zSf2lqh5KIo7TEgzRLmuKL05NYVIkQSWwzSf/QOPnGtvMeJOFq5onaswnHofU1s3VnbRpS+Zof8T0r26adNQdFkKxtyEXcYGvxfHzKz5xB/jEc6y6TTHJ/g==;20:VKgCW+NxX6f9HQyNFS8Jqw0AoLkMcN8w74eQdZiw5AG0kDcxztIA18roOXE0DWodqIZh9Yl50sD36ElrsnPDxiymdXEfrANfthD48fFtD7HdHh0rivYpmnGcVSLYVQPaY1g7sRorhiUI1Rt8ne3cJT2bUYuI17S73OL6DvCGtf4= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2017 06:24:04.0462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR05MB2336 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/2017 03:29 AM, Michel Dänzer wrote: > On 26/01/17 09:46 AM, Sinclair Yeh wrote: >> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: >>>> On 01/25/2017 09:21 AM, Michel Dänzer wrote: >>>>> From: Michel Dänzer >>>>> >>>>> The current caching state may not be tt_cached, even though the >>>>> placement contains TTM_PL_FLAG_CACHED, because placement can contain >>>>> multiple caching flags. Trying to swap out such a BO would trip up the >>>>> >>>>> BUG_ON(ttm->caching_state != tt_cached); >>>>> >>>>> in ttm_tt_swapout. >>>>> >>>>> Cc: stable@vger.kernel.org >>>>> Signed-off-by: Michel Dänzer >>>> Reviewed-by: Thomas Hellstrom >>> Reviewed-by: Christian König . >> Reviewed-by: Sinclair Yeh > Thanks for the reviews! Via which tree should we merge this? > > I don't maintain a TTM tree any longer. Let's check with Daniel if he can merge it through drm-misc. /Thomas