From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932551AbcGDDbf (ORCPT ); Sun, 3 Jul 2016 23:31:35 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:37830 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932386AbcGDDbc (ORCPT ); Sun, 3 Jul 2016 23:31:32 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f79476d000001429-69-5779d891f93e Content-transfer-encoding: 8BIT Message-id: <5779D891.30405@samsung.com> Date: Mon, 04 Jul 2016 12:31:29 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Peter Chen , myungjoo.ham@samsung.com, kyungmin.park@samsung.com Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski Subject: Re: [PATCH v2 1/1] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle References: <1467600466-13667-1-git-send-email-peter.chen@nxp.com> In-reply-to: <1467600466-13667-1-git-send-email-peter.chen@nxp.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsWyRsSkQHfijcpwg+PLDSxevzC06H/8mtni bNMbdotNj6+xWlzeNYfN4nPvEUaLGef3MVncblzBZvHn3h1WB06PTas62Tw2L6n32PhuB5NH 35ZVjB6fN8kFsEZx2aSk5mSWpRbp2yVwZcw+vJy5YDlvxa6+l+wNjI+5uhg5OSQETCTaVmxh gbDFJC7cW8/WxcjFISSwglHi0JZ1jDBFu743skAkZjFKzF/8hxUkwSsgKPFj8j2gBAcHs4C8 xJFL2SBhZgF1iUnzFjFD1D9glLi+cAITRL2GRM+OJWD1LAKqEk1XPUHCbAJaEvtf3GADCYsK REh0n6gECYsIREk8OXqUCWQMs8BVRokHG/6D3SMskCkx7fp0dhBbSGAGo8T2Y/EgNqeAs8TC U88ZQRokBB6xS/w7u40ZJMEiICDxbfIhsL0SArISmw4wQ/wlKXFwxQ2WCYxis5B8Mwvhm1lI vlnAyLyKUTS1ILmgOCm9yFivODG3uDQvXS85P3cTIzAGT/971r+D8e4B60OMAhyMSjy8D65W hguxJpYVV+YeYjQFOmIis5Rocj4w0vNK4g2NzYwsTE1MjY3MLc2UxHkXSv0MFhJITyxJzU5N LUgtii8qzUktPsTIxMEp1cAYqF4b37zvfIRv/dLrR/L2n+W3ChX947vT88ps7ck3OW9I+0RV 7r8dfkbzwZNXIdqVBuWvzBZG5W4Q5pZwL5N76nWi5oJmz+uNCZE/JzS7KXisyNirtZFN//Qz 3ukpS+M5/3A8tlrL9Oc454RXISzvTO+2//5gfv9io2qTer2fnqfKxuWRa6SUWIozEg21mIuK EwGIa/zBvAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsVy+t9jQd2JNyrDDe4d1rJ4/cLQov/xa2aL s01v2C02Pb7GanF51xw2i8+9RxgtZpzfx2Rxu3EFm8Wfe3dYHTg9Nq3qZPPYvKTeY+O7HUwe fVtWMXp83iQXwBrVwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk 4hOg65aZA3SPkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwhjFj9uHlzAXL eSt29b1kb2B8zNXFyMkhIWAiset7IwuELSZx4d56ti5GLg4hgVmMEvMX/2EFSfAKCEr8mHwP qIiDg1lAXuLIpWyQMLOAusSkeYuYIeofMEpcXziBCaJeQ6JnxxKwehYBVYmmq54gYTYBLYn9 L26wgYRFBSIkuk9UgoRFBKIknhw9ygQyhlngKqPEgw3/GUESwgKZEtOuT2cHsYUEZjBKbD8W D2JzCjhLLDz1nHECI9CRCNfNQrhuFpLrFjAyr2KUSC1ILihOSs81zEst1ytOzC0uzUvXS87P 3cQIjvNnUjsYD+5yP8QowMGoxMNr2VsZLsSaWFZcmXuIUYKDWUmEd/FVoBBvSmJlVWpRfnxR aU5q8SFGU6D3JjJLiSbnA1NQXkm8obGJmZGlkbmhhZGxuZI47+P/68KEBNITS1KzU1MLUotg +pg4OKUaGLkk3FmDf9QElOmcsErdsqnl9jSOif1OhRle8548vb1K1u/NXpWy8udN552frXmy PpZJ2/7t9Au5q9/dfiPT+0v6mJ/8mpybF3IfCAeVdHCm3iu7apamJxFZYHlgVZS2pIAer4FI 7LPjH+MSnPb/lzqRM/XykmApx+XmHEd5f11jfZhheXsLqxJLcUaioRZzUXEiAH9RYjoJAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 07월 04일 11:47, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Chanwoo Choi > Cc: MyungJoo Ham > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Signed-off-by: Peter Chen > --- > > Changes at v2: > - It should define node as pointer, kbuild test robot reports it > > > drivers/devfreq/exynos-bus.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c > index 2363d0a..4b4c63c 100644 > --- a/drivers/devfreq/exynos-bus.c > +++ b/drivers/devfreq/exynos-bus.c > @@ -383,7 +383,7 @@ err_clk: > static int exynos_bus_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct device_node *np = dev->of_node; > + struct device_node *node, *np = dev->of_node; > struct devfreq_dev_profile *profile; > struct devfreq_simple_ondemand_data *ondemand_data; > struct devfreq_passive_data *passive_data; > @@ -415,10 +415,13 @@ static int exynos_bus_probe(struct platform_device *pdev) > goto err; > } > > - if (of_parse_phandle(dev->of_node, "devfreq", 0)) > + node = of_parse_phandle(dev->of_node, "devfreq", 0); > + if (node) { > + of_node_put(node); > goto passive; > - else > + } else { > ret = exynos_bus_parent_parse_of(np, bus); > + } > > if (ret < 0) > goto err; > Acked-by: Chanwoo Choi Thanks, Chanwoo Choi