From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754538AbcGEKDg (ORCPT ); Tue, 5 Jul 2016 06:03:36 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37050 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcGEKDc (ORCPT ); Tue, 5 Jul 2016 06:03:32 -0400 Subject: Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver To: Wan Zongshun , linux-arm-kernel@lists.infradead.org, Russell King , devicetree@vger.kernel.org References: <1466851042-22239-1-git-send-email-vw@iommu.org> <1466851042-22239-4-git-send-email-vw@iommu.org> <5771827E.1090609@linaro.org> <577B6DFF.9000703@iommu.org> Cc: Thomas Gleixner , Wan Zongshun , linux-kernel@vger.kernel.org, Arnd Bergmann From: Daniel Lezcano Message-ID: <577B85F1.9010004@linaro.org> Date: Tue, 5 Jul 2016 12:03:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <577B6DFF.9000703@iommu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/2016 10:21 AM, Wan Zongshun wrote: [ ... ] >>> + setup_irq(irq, &nuc970_timer0_irq); >> >> s/setup_irq/request_irq/ > > Do you think I should use request_irq instead of setup_irq? Yes. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog