From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbcGEWxm (ORCPT ); Tue, 5 Jul 2016 18:53:42 -0400 Received: from mail-dm3nam03on0067.outbound.protection.outlook.com ([104.47.41.67]:19808 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750757AbcGEWxj (ORCPT ); Tue, 5 Jul 2016 18:53:39 -0400 X-Greylist: delayed 8370 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Jul 2016 18:53:39 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <577C1661.5000106@caviumnetworks.com> Date: Tue, 5 Jul 2016 13:19:45 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Will Deacon CC: Paul Gortmaker , , Bjorn Helgaas , , , , Subject: Re: [PATCH 04/14] PCI: generic: make it explicitly non-modular References: <20160702231334.26684-1-paul.gortmaker@windriver.com> <20160702231334.26684-5-paul.gortmaker@windriver.com> <20160704173752.GR1639@arm.com> In-Reply-To: <20160704173752.GR1639@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: BN1PR07CA0053.namprd07.prod.outlook.com (10.255.193.28) To BN4PR07MB2131.namprd07.prod.outlook.com (10.164.63.13) X-MS-Office365-Filtering-Correlation-Id: d34f6556-cd89-486f-3335-08d3a511b63c X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2131;2:FG7Dv96Ej1UEtagdJppFexE27Ybmc6Bq6BLoJIksa1/RzgKNTs1vISVk8FLglO9MulPcXnQsmVwqu3zlxt7Br+v4aT3big/HHGetVldDQz4aneEG0SfQaWZoiRbJN/9YXpqDCY4sQ69n5OzpwrElbcSyw5LqtRXRGR9kc+ZKpr3i8Wnwlw6diQRgK9qos3qn;3:7U1zhwl0iWyQgF3eUPHAVSfXvvXqytpOVuXV+3WdQZ0YJ1ACJj67Rt0RZMAZ74/7y+MYDm6hHarrbhDaTkiuM9kPY7nyVlBVS2OCqQkE2vbKUeQ/FxW64smoM6wBtWmQ;25:1zMbIjEl/ium/cz4AFHyHOKmb0qCW0+iLQ5xFDKuBfhecfPEzXPmsH492sZHQ+Yoj7Gb2V0cZqcpz/XhmLaz59K4vW+ATHEMF/Myggufo3GVwJ2eLxmKOwSQd2pNki/3aoUsVw4FFT+oEMisL7DR70SSFyXNrEMLH4S+KIWegXOpWd0erGhLm+koUrz2IvxF3TsG0jN4eCxiaeXEI3xXQnLXM+cxbz6tHKVQppeMaeZpDYqO855ga7TR01B3CJoOlr7+TXYftVk3iL1nzkli5yIIgN298gCFDICDXkY7a5VECVojfoOa+0thK304vGmIr1XlIfkrWVRDcJvZzbY4BCUS/IELqD0cGH9mZxUA5DNA5Z7K/C1MkH7jNW2MBJDif0jrcKdbKE7+e49gUqrFfpyrUKwGYqHRXPxIW8KP3PE=;31:wMuaPB+P3PkQP9UHKIExEdwM7O4e8h8b/1ogC7CR4Cu7FXV7GKz2+H7ayUqZpFVhYlMmBPaGwW5CCusQhOxFVOlX1qPnr6bHh4K8Y2p6BnLwYZbSlJSF0PJNDEEBSeRYPSFHCfpvmsiMA1v+RcJ9JoGnuQgMEqB6t7WrDTe8K07y6wxHg+rl1NQL0iWUSxnOFzpzz4pdXtmtnxZZT5gjRA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2131; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2131;20:hmTqsCVT4cUpmlcV5XrMjv5mDHzdAlqyZKtTI4XMUeC2wlOwzilBhc7mSt83DJ0VIwLQv311XAPCBGxxmQPUwHIBIB66lxYLxyWokFec6c2keH+FQ2sQaVWg/ZmDiyu3m2UDF2/QFdhGctRvWZi6LWQV3c90pKwxGPhuWs3/ogxUdSNXtAQSW6fbXTkzkTml9et8m+5tnwtAn78Pjjmw4kWQZ/ZLyhCaFB2H3KTwWMNUpeuUlTE0yUxENVMG0Qlg7Pr3hHzwD+9soTWDbf6dlE8H/SExXunJt3a/sn1EYswoHvvf7diQN9jhdWewF9SJ0ozcrdypSbL844DepwewCK/27PJbxcnVaBbWBiL82h+9tlsc/KJ9B/J845MiDe1TtDEZO0278yT74xMCcca7EfMfarhUYL9xsUWxGHRB/vydxGQgQJJoXw2z6m+u6E+mBrd3w/OqM1/RUVO9uJecPdcv97Bl5nqNXYbvW/OjQfQNJ6V5yXLJA1gU3zeBYWaCxbUy5BN/OLTlDpS9LYiDkfRDAYHUsFo/sqaAr3usrJg7iN+7HFqxqHwQSV2v5UFvvcoEHx/lG0cq3fcoPdbMHUpSA8XqoDWaBwRyI6P+u1w= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BN4PR07MB2131;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2131; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2131;4:8kl8LbEyex5d6uPHgV+Whd6gkis+iPNCTLjUCT9dh3J0MXkhUQIxAv5ZFwgQFsWVKCC4m7WTbPsIQQcVlyhYoHSSBS6OZPqVNZCAhN0wFrxovkf2RTL2ekxaYNDSHgOaJKVRfYif8LknXrGMmnkk0lT9GvR+QwyqN/U6Hd+Qwu5jNEE+uA+zIx0LXTLIbjOuxdVx2N7Igq5ysVyM+Ss3b/thEpPwBQm81wyxw9IZtPxfy0suztHr2qa12CX9Y3Mfv+yPtPoujAEmFHOLYv+G/bIBUTamgkWVLr3YbVNsj4ZR/t5pD8L8kmbyK0gTLNflX2oCGAUS8sNfK4b+R4bIqZnxNK3SlJjiZ/7VJt19Ya3pb/ZlC5vylsbGHFafe1IZ X-Forefront-PRVS: 0994F5E0C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(377454003)(189002)(24454002)(6116002)(3846002)(586003)(68736007)(50466002)(23756003)(77096005)(7846002)(59896002)(76176999)(4001350100001)(69596002)(87266999)(54356999)(83506001)(33656002)(50986999)(230700001)(65816999)(97736004)(81166006)(80316001)(305945005)(106356001)(2906002)(110136002)(42186005)(53416004)(189998001)(105586002)(8676002)(36756003)(81156014)(101416001)(2950100001)(92566002)(65806001)(47776003)(4326007)(66066001)(65956001)(7736002)(64126003)(41533002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2131;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN4PR07MB2131;23:NvGx3FCv6kPBol6gUsC0Wu1kdVRGZDVRBiNIm1d?= =?iso-8859-1?Q?fENDrj83SrCMZKXYFhH+PiPWm+nmGGS6NDeeFGL05avv/xSWvXU2L9Lum1?= =?iso-8859-1?Q?sx7XTmgL8WSrT2Ng2m19bXGNYUQxupEqfWx98I2jv32fTACGH/psIwgQhY?= =?iso-8859-1?Q?CUXA7QeUdeaxO9Osq358lIm2R/u6ZVFOJKjY341GdjK2+2IFYzlZK5Mp6i?= =?iso-8859-1?Q?cRLQlEgnHTVLJcfl7+N/Ddn/ce/kmH5hgVzHcde1qwAlGzDd5EWsjv1pMK?= =?iso-8859-1?Q?0ZAU+UhO93YoYTfy7aHAWcZZpZ+XtdP/2KzOYcSi9xWv5g3FQ8TELHicb+?= =?iso-8859-1?Q?NI4p4x8pYPel07uvXJPhupUqgsN9egExP7HzEoxuD7ZktMGExFi66Z/Xa4?= =?iso-8859-1?Q?qfCWlz2UJyaOngMjz6AyhSor8iQO+43cDq2Vco0sc12F67g3M2ae0hdt8H?= =?iso-8859-1?Q?tfelS/wZ215NIR8ppI3PrpVZX0PgDUXMNkJc6zVktdkjywCNQj0SjCwugo?= =?iso-8859-1?Q?WL58zYzNAjqyC/9Otn0Oc17YMkhu7BzuL+1aj/7YEkZWECvIJZlx0eYjit?= =?iso-8859-1?Q?CnvM/qqkQkxcXv4hiEq8XlCnOTYYKi/u2u/Vo31gHjQZfP+jgUc3lyPDlF?= =?iso-8859-1?Q?rjGvPWN2IFIKm8Al/iN8AW5IfFjfaakMrCuq9LHVs2l0qd0S1z1Q9JMkZj?= =?iso-8859-1?Q?Sw1Jgq//2EF7udLB353SdMFbTZHaKm3KAwaC9/APozmTycPvH56h/uxIYD?= =?iso-8859-1?Q?5I+8CvA61aR+tbOpqWdNR49FzvOezDXflzlTbcP8esithi/uaxrpCwAJRf?= =?iso-8859-1?Q?/eymOhG94Yi4IWffilcdNpNyRNCGsrtul5/w4SqXZfcn05Gl1xj4K7eAWI?= =?iso-8859-1?Q?UykDxOJtmWSIy97tlpgrS10yROdrKOpwy9TfuappDTf9ffq2GptIqAArXK?= =?iso-8859-1?Q?DFWJD2J5ncEfmbm0HbkEbQ76VCh8aFTTfoj2vvrVCSrNWb6n0zlmCl3ivV?= =?iso-8859-1?Q?pTVLsumQ/p8Afns8aCL86O3ikPV7/K1oK0QTeCAXswFtkx4mQmb+dLxvAq?= =?iso-8859-1?Q?67JOy41CW9+syKQq/klNNaVI7ydTPuWZNyt/3Qe2wq3AJLqzekxIrb7eUT?= =?iso-8859-1?Q?hEmstizjLkGuU3YYWky851Oc6t/Cb5NQ6lOW3MFjL6+t44xyMMISflnWrs?= =?iso-8859-1?Q?rOSniXt95zNl19K1Nq2kIPJRdKqixl70Uy5lmjcbb5BDyYRMo/kun9kDOO?= =?iso-8859-1?Q?fwjyHmXtADXwnLMYJ/CGe+k5N6bODy6i8ngOQH3fqR8/NDTLvys1wHoWc7?= =?iso-8859-1?Q?B4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2131;6:U3DNIrQjhb7/OCt/YCWtr2tj+kkVELpxM/AI6RpLvlLMsffgEEiM0vPXiwr1wkBKHXxbD5KRR+/itSKql4Gk/TAQm+n7+Wpaq4VEHGx01+dowD6li5v92upPd8MCT1bNRjAVkSYpismy1sL8qRE8QDhoOWFqI7+hBfaoRG0PwesWcfz2ffsh+jcq4+7nHhpivQZrZwfUPLq8rw4Zu6uQc9VhWRx6JacJeCskkcgN2y7FC6MH7tOT1gQtOu/+MHX6sbtYc/H7bJ9k6+ePnRMq+kEvSFL03Cg8xouuSsvuIiU=;5:m0kl2La7PLy7UghaonhwfOq1Ke4MwRY+fc4PCrexOvA8rDryaHU5m2plkfbKKyS4SnizQTt8f9DDOEMwmzzGSP39oClIwopEon7aZ/HXpZy6FTrw3aRI4hi50t+XoFKrDrArLR2YkMgvlOqNa9jPYA==;24:7vhHU48Z2tQLZKXAtSa9hELVcJvRtFMYwBUbu54fVSPja3KyvS3UZiODVCDwt5FY8oFcjKGkHKbOj8/GzXRmk8Ax8llndNIa/xhZD+M4akU=;7:HF6FXkANqQE9LzFOZEssVzxjm8o13baGG3SGbQT2Olo/QMc+NhYsQjNDTd7nNaHYfP5E4ZgyyCjHN2ets4TZZ8Xrtn+YQ5mwDm7EJRs+tBLSlQmT4qzAm7WyF146VFDxAG3IydyaXifxIM1Sko9fKDOr16WXZ0aMXBdDh5IaxYFkrd2QuoQjeLxNqnIajmfR03uqrPbyDiALZXBTXX9fOFmPnti+eean2pLj3ltoedpphSrnxgsq8nh7n1f7JBuk SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2016 20:19:47.2561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/2016 10:37 AM, Will Deacon wrote: > On Sat, Jul 02, 2016 at 07:13:24PM -0400, Paul Gortmaker wrote: >> The Kconfig currently controlling compilation of this code is: >> >> drivers/pci/host/Kconfig:config PCI_HOST_GENERIC >> drivers/pci/host/Kconfig: bool "Generic PCI host controller" >> >> ...meaning that it currently is not being built as a module by anyone. >> >> Lets remove the few trace uses of modular code and macros, so that >> when reading the driver there is no doubt it is builtin-only. >> >> Since module_platform_driver() uses the same init level priority as >> builtin_platform_driver() the init ordering remains unchanged with >> this commit. >> >> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. >> >> We also delete the MODULE_LICENSE tag etc. since all that information >> is already contained at the top of the file in the comments. > > Ideally, we'd simply fix this to build as a module, but it's not clear > how to do that now that the ecam accessors have been split out into > their own file. A liberal sprinkling of EXPORT_SYMBOL might work, but > it's a bit grotty. > > David, Jayachandran -- do you have any desire to build your PCI host > controller drivers as modules? I can only speak to the Cavium case. The system is not usable without PCI, so there is no advantage to making the PCI host drivers modular. At this point I don't see any reason to expend effort making it work as a module. David. > > Will >