From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753295AbcGFG6X (ORCPT ); Wed, 6 Jul 2016 02:58:23 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:38205 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbcGFG6W convert rfc822-to-8bit (ORCPT ); Wed, 6 Jul 2016 02:58:22 -0400 Message-Id: <577CC82B02000078000FB7BA@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Wed, 06 Jul 2016 00:58:19 -0600 From: "Jan Beulich" To: "David Vrabel" , "Boris Ostrovsky" , "Jan Beulich" , "Juergen Gross" Cc: "xen-devel" , Subject: [PATCH v4 4/7] xen-pciback: simplify determination of 64-bit memory resource References: <577CC59602000078000FB7A0@prv-mh.provo.novell.com> In-Reply-To: <577CC59602000078000FB7A0@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Other than for raw BAR values, flags are properly separated in the internal representation. Signed-off-by: Jan Beulich --- drivers/xen/xen-pciback/conf_space_header.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- 4.7-rc6-xen-pciback.orig/drivers/xen/xen-pciback/conf_space_header.c +++ 4.7-rc6-xen-pciback/drivers/xen/xen-pciback/conf_space_header.c @@ -222,10 +222,7 @@ static void *bar_init(struct pci_dev *de pos = PCI_ROM_RESOURCE; else { pos = (offset - PCI_BASE_ADDRESS_0) / 4; - if (pos && ((res[pos - 1].flags & (PCI_BASE_ADDRESS_SPACE | - PCI_BASE_ADDRESS_MEM_TYPE_MASK)) == - (PCI_BASE_ADDRESS_SPACE_MEMORY | - PCI_BASE_ADDRESS_MEM_TYPE_64))) { + if (pos && (res[pos - 1].flags & IORESOURCE_MEM_64)) { bar->val = res[pos - 1].start >> 32; bar->len_val = -resource_size(&res[pos - 1]) >> 32; return bar;