From: Joseph Salisbury <joseph.salisbury@canonical.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: hdegoede@redhat.com, adrienverge@gmail.com, yaowen@google.com,
vpalatin@chromium.org, stern@rowland.harvard.edu,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad
Date: Wed, 6 Jul 2016 20:24:18 -0400 [thread overview]
Message-ID: <577DA132.9040204@canonical.com> (raw)
In-Reply-To: <20160706231058.GB22668@kroah.com>
On 07/06/2016 07:10 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 05:53:47PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power Management so
>> adding a quirk. This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
>> Cc: stable <stable@vger.kernel.org>
>>
>> ---
>> drivers/usb/core/quirks.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..a33d003 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>> /* Protocol and OTG Electrical Test Device */
>> { USB_DEVICE(0x1a0a, 0x0200), .driver_info =
>> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>> +
>> + /* ELAN Microelectronics Touchscreen */
>> + { USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },
> Please put this next to the other Elan touchscreen quirk entries, don't
> put them in random order, it's a pain to maintain that way...
>
> thanks,
>
> greg k-h
Sorry, I grouped it with the other USB_QUIRK_NO_LPM entries. I'll send
a V2 patch and make a note to group by manufacturer from now on.
Thanks,
Joe
next prev parent reply other threads:[~2016-07-07 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1467421035.git.joseph.salisbury@canonical.com>
2016-07-06 21:53 ` Joseph Salisbury
2016-07-06 23:10 ` Greg KH
2016-07-07 0:24 ` Joseph Salisbury [this message]
2016-07-08 1:05 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577DA132.9040204@canonical.com \
--to=joseph.salisbury@canonical.com \
--cc=adrienverge@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vpalatin@chromium.org \
--cc=yaowen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome