From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756549AbcGGHiP (ORCPT ); Thu, 7 Jul 2016 03:38:15 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:47365 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756532AbcGGHiN convert rfc822-to-8bit (ORCPT ); Thu, 7 Jul 2016 03:38:13 -0400 Message-Id: <577E230502000078000FBE0D@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 01:38:13 -0600 From: "Jan Beulich" To: "Roger Pau Monne" , "Konrad Rzeszutek Wilk" Cc: , Subject: [PATCH] xen-blkback: really don't leak mode property Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 9d092603cc ("xen-blkback: do not leak mode property") left one path unfixed; correct this. Signed-off-by: Jan Beulich --- drivers/block/xen-blkback/xenbus.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- 4.7-rc6-xen.orig/drivers/block/xen-blkback/xenbus.c +++ 4.7-rc6-xen/drivers/block/xen-blkback/xenbus.c @@ -715,8 +715,11 @@ static void backend_changed(struct xenbu /* Front end dir is a number, which is used as the handle. */ err = kstrtoul(strrchr(dev->otherend, '/') + 1, 0, &handle); - if (err) + if (err) { + kfree(be->mode); + be->mode = NULL; return; + } be->major = major; be->minor = minor;