From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756749AbcGGIGR (ORCPT ); Thu, 7 Jul 2016 04:06:17 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:56067 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756266AbcGGIGM convert rfc822-to-8bit (ORCPT ); Thu, 7 Jul 2016 04:06:12 -0400 Message-Id: <577E299402000078000FBF24@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 02:06:12 -0600 From: "Jan Beulich" To: "Roger Pau Monne" , "Konrad Rzeszutek Wilk" Cc: , Subject: [PATCH] xen-blkback: prefer xenbus_write() over xenbus_printf() where possible Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... as being the simpler variant. Signed-off-by: Jan Beulich --- drivers/block/xen-blkback/xenbus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkback/xenbus.c +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkback/xenbus.c @@ -617,9 +617,9 @@ static int xen_blkbk_probe(struct xenbus goto fail; } - err = xenbus_printf(XBT_NIL, dev->nodename, - "feature-max-indirect-segments", "%u", - MAX_INDIRECT_SEGMENTS); + err = xenbus_write(XBT_NIL, dev->nodename, + "feature-max-indirect-segments", + __stringify(MAX_INDIRECT_SEGMENTS)); if (err) dev_warn(&dev->dev, "writing %s/feature-max-indirect-segments (%d)", @@ -850,7 +850,7 @@ again: xen_blkbk_barrier(xbt, be, be->blkif->vbd.flush_support); - err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "%u", 1); + err = xenbus_write(xbt, dev->nodename, "feature-persistent", "1"); if (err) { xenbus_dev_fatal(dev, err, "writing %s/feature-persistent", dev->nodename);