From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756769AbcGGIGi (ORCPT ); Thu, 7 Jul 2016 04:06:38 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:60469 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756266AbcGGIGf convert rfc822-to-8bit (ORCPT ); Thu, 7 Jul 2016 04:06:35 -0400 Message-Id: <577E29A902000078000FBF28@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 07 Jul 2016 02:06:33 -0600 From: "Jan Beulich" To: "Roger Pau Monne" , "Konrad Rzeszutek Wilk" Cc: , Subject: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... as being the simpler variant. Signed-off-by: Jan Beulich --- drivers/block/xen-blkfront.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c @@ -1825,14 +1825,13 @@ again: } kfree(path); } - err = xenbus_printf(xbt, dev->nodename, "protocol", "%s", - XEN_IO_PROTO_ABI_NATIVE); + err = xenbus_write(xbt, dev->nodename, "protocol", + XEN_IO_PROTO_ABI_NATIVE); if (err) { message = "writing protocol"; goto abort_transaction; } - err = xenbus_printf(xbt, dev->nodename, - "feature-persistent", "%u", 1); + err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1"); if (err) dev_warn(&dev->dev, "writing persistent grants feature to xenbus");