From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933413AbcGGKA0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jul 2016 06:00:26 -0400
Received: from prv-mh.provo.novell.com ([137.65.248.74]:50346 "EHLO
	prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933298AbcGGKAW convert rfc822-to-8bit (ORCPT
	<rfc822;groupwise-linux-kernel@vger.kernel.org:4:1>);
	Thu, 7 Jul 2016 06:00:22 -0400
Message-Id: <577E445502000078000FC153@prv-mh.provo.novell.com>
X-Mailer: Novell GroupWise Internet Agent 14.2.0 
Date: Thu, 07 Jul 2016 04:00:21 -0600
From: "Jan Beulich" <JBeulich@suse.com>
To: "Roger Pau Monne" <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
        "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen-blkfront: prefer xenbus_write() over
 xenbus_printf() where possible
References: <577E29A902000078000FBF28@prv-mh.provo.novell.com>
 <20160707094405.mgv6uykxmqsq4fi2@mac>
In-Reply-To: <20160707094405.mgv6uykxmqsq4fi2@mac>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> On 07.07.16 at 11:44, <roger.pau@citrix.com> wrote:
> On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
>> ... as being the simpler variant.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>>  drivers/block/xen-blkfront.c |    7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>> 
>> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
>> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
>> @@ -1825,14 +1825,13 @@ again:
>>  		}
>>  		kfree(path);
>>  	}
>> -	err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
>> -			    XEN_IO_PROTO_ABI_NATIVE);
>> +	err = xenbus_write(xbt, dev->nodename, "protocol",
>> +			   XEN_IO_PROTO_ABI_NATIVE);
>>  	if (err) {
>>  		message = "writing protocol";
>>  		goto abort_transaction;
>>  	}
>> -	err = xenbus_printf(xbt, dev->nodename,
>> -			    "feature-persistent", "%u", 1);
>> +	err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
> 
> AFAICT you forgot to replace xenbus_printf with xenbus_write here.

Oops, indeed - thanks for noticing.

Jan