From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753060AbcGGP5U (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jul 2016 11:57:20 -0400
Received: from prv-mh.provo.novell.com ([137.65.248.74]:57811 "EHLO
	prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750952AbcGGP5M (ORCPT
	<rfc822;groupwise-linux-kernel@vger.kernel.org:4:1>);
	Thu, 7 Jul 2016 11:57:12 -0400
Message-Id: <577E97F602000078000FC546@prv-mh.provo.novell.com>
X-Mailer: Novell GroupWise Internet Agent 14.2.0 
Date: Thu, 07 Jul 2016 09:57:10 -0600
From: "Jan Beulich" <JBeulich@suse.com>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>,
        "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: "Roger Pau Monne" <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-blkback: constify instance of
 "struct attribute_group"
References: <577E233202000078000FBE11@prv-mh.provo.novell.com>
 <20160707094535.wsgrxlnib5ajcsdc@mac>
 <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com>
 <20160707153750.GB11480@localhost.localdomain>
In-Reply-To: <20160707153750.GB11480@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote:
> On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
>> On 07/07/16 10:45, Roger Pau Monne wrote:
>> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> >> The functions such get passed to have been taking pointers to const
>> >> since at least 2.6.16.
>> >>
>> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>> >
>> > Although the wording in the commit message looks weird to me, but I'm not a 
> 
>> > native speaker anyway.
>> 
>> As a native speaker, I can't parse it either.
>> 
>> I think s/such/these/ is needed.
> 
> The functions such as these have been taking pointers to const
> since at least 2.6.16. 

I had taken Andrew's suggestion literally and changed it to "The
functions these get passed to have been taking pointers to const
since at least 2.6.16" for a possible (if needed) resubmission.

Jan