From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755031AbcGHMZs (ORCPT ); Fri, 8 Jul 2016 08:25:48 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:45053 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbcGHMZk convert rfc822-to-8bit (ORCPT ); Fri, 8 Jul 2016 08:25:40 -0400 Message-Id: <577FB7E302000078000FCA18@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Fri, 08 Jul 2016 06:25:39 -0600 From: "Jan Beulich" To: , , "Juergen Gross" Cc: , Subject: [PATCH v2 1/4] xenbus: prefer xenbus_scanf() over xenbus_gather() References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> In-Reply-To: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For single items being collected this should be preferred as being more typesafe (as the compiler can check format string and to-be-written-to variable match) and more efficient (requiring one less parameter to be passed). Signed-off-by: Jan Beulich --- v2: Avoid commit message to continue from subject. --- drivers/xen/xenbus/xenbus_client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/xen/xenbus/xenbus_client.c +++ 4.7-rc6-prefer-xenbus_scanf/drivers/xen/xenbus/xenbus_client.c @@ -926,9 +926,9 @@ EXPORT_SYMBOL_GPL(xenbus_unmap_ring); */ enum xenbus_state xenbus_read_driver_state(const char *path) { - enum xenbus_state result; - int err = xenbus_gather(XBT_NIL, path, "state", "%d", &result, NULL); - if (err) + int result; + + if (xenbus_scanf(XBT_NIL, path, "state", "%d", &result) != 1) result = XenbusStateUnknown; return result;