From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24BF919F121 for ; Mon, 19 Oct 2026 12:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792413549; cv=none; b=c/Gw5GDph+4E3SKYY2JOGrfv63ItH0ltw0NBj5dp1icyWPHqX8nzfNYSuip4Y9WIMybk545xnDZztteYNvzYdEYnvn/0p3ZcWS5n2l4JT7IDXKTafNvbg9v8oEPy4tPW/r6gt6RPW/VUgnvW1DLZ4m8pbwJnYogf/orAadeQtVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792413549; c=relaxed/simple; bh=vFGazr0aQJt5RzuoQR4G3P0EOLka2JyrVxwz8bszgBA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bRoiMvDtpa+1UGurdn+qCCvij2RmpZCxnSZdWlPCombY/PxbfjvBq+k03T/um7mR2/IxqndPdIyJvRHqTY0+FX3q276W1WSEJMHfMwNuCiYA8WZar1e1UmkF2aVfJVa+LRy3pI8yFv6HymE19RaPZx+8IpB3oJt9dqJo6Y2b4lI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VKfriVX6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cwq9w2Fo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VKfriVX6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cwq9w2Fo" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69J8Oxkj1168083 for ; Mon, 19 Oct 2026 12:38:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= g1Zf5nmoOj9REwHL4lFlJcEi+BQNp7U+4/drZJjgFKQ=; b=VKfriVX6+qAmBvUJ S8rJfWLOJCjLIbcmSEVYqEzztxPtl5o79LqZy5oHNHvsBo5dEqLzhI0Rbq8QUBv4 yYcprXqTM4vdCJ8FPy+oUSH9oSC/uPvJ7ZlTyryUqP5qnFXXYfjTyDMXK8RVdpgn cQRhy7ChJwjoYmjQ1BPWNVDeE70uOq31+d7ei4uIaIUpgiblSPihTnRbHj/CksRt iSx5UgSfBavR+b3Y0hCrFvT3G0LPYYP5npEQDj9VlCymd32jFu3f3Lg6qV0tt10b Bw2qjF81gxaHnF6V1FyvcKsqCV0EutBxEowj0y1q1+dHtYwHk7dKSFRDrdWNjLPZ 7mUaNA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdf5c92qd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Oct 2026 12:38:55 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93edac5877bso37402885a.1 for ; Mon, 19 Oct 2026 05:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792413535; x=1793018335; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g1Zf5nmoOj9REwHL4lFlJcEi+BQNp7U+4/drZJjgFKQ=; b=cwq9w2FoU4Je0ZSC6/u1Fy4IoqSnQcHEwJ3U+41qODM0xWP/M6q12XnCllCMoIGSA6 hzJnZxydDRRt6NtH/W6gzVBkJYWFuk+F0vuqGY1ixfvVw7Bmv60qali56DGPfaJ0NnQM 2VwU+0/T52ZRRuCWX/6eLOY6iIU3tGe1rT3G8rIEUptC82KVlWJiSyj3djQVs/NLOka5 lFAXQthvE7+JGqItaHo4fEAxlgT99pjRexUMtAV3MVtVprWwrVbrIuOFg0XmBOUBsrEk oEKzOHNR6ksEgBOcZDBawimytQQn1NS43dxoIdklm7Dg2I/Yxcsy8DjeFB0/7jwSZaH1 malQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792413535; x=1793018335; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g1Zf5nmoOj9REwHL4lFlJcEi+BQNp7U+4/drZJjgFKQ=; b=YxVAkvzNcbZ4l5t6+j8huZyHeRl6kPO3nZHyIqfRy4/+V7/ak5L+UTQwLTUg1jiKSr tAMV7ORRmXXHLJQXd1RbI+gQeP005RBe6m1M333VMvs5QYAI9vuVFJPHgA7w+Jz3tGwv HdtY7tc3yzsFAynHvSpvXGElTPfXULBZIP/jjkZf3G19rqS0l/bVGwbxAAT/Hv+ANAxA HbJLWUA5GatUo/+g7mfIg6xbTKty01mk8tyqlCOenH+ZpeVkoew4vyxFvYHtiP5T13tj 37uFKadGB8ScvSyejN0rHIUKjKvQ6wvLKtXd9P30xJxxTKsDjYGTzuqWhT7f4lDqrOuN 8Xfg== X-Forwarded-Encrypted: i=1; AKwUvBxi3ux1qMEZ4ZW+pLyaVifDTUR6r6uitoWgRRvxJ4Fjjp6tA6yFc7sNRkZRDmLu1E2h/1yfmW4lnc460xY=@vger.kernel.org X-Gm-Message-State: AFq9FYKaF6GH7XnjB8AIBxmtQn+LNMuex3LMhZwBkh2fkTr37kBTkxoR kJh5/SVwsaykxX/dzI692Otvuknuvre6GrLdpWJNVEu9VCVp3Q4dSfQNJ5eRtHfLGgOUwwnbahn k2AY+6M3LxpyjbDXDZUMJhqSrNwQ/382t+d9vJZZeJKIOxMw00/DSVifIqpsm7TkLSE0= X-Gm-Gg: AYBFou3bdjKGwsij6jzLlzr7g7Du7D2NhTD2g+V1B7nnMCoUbx/3qkhFfh2wxGuSbsH GByM2L+700Vj6r/VGn7xKydVHxeONNItH9pZgevgLuh7ihfefAkTHmnKDdohVnyCFjb28RdR/xQ rNg7AxDwJ5yqTidyvW6F2IMLkmIjbC0yZvF2bRlafLKf1iPXUuEPX/l2BEWhd0hLczOPrXgWm4A nuFLxXNIsUFkmPwVv/aFB4XFaFeZeSwj+irCdz2NTykQ19y/1FVIXqpPKQOY332L1hGL6mEYlLO Ze7kujrjxXVfJbaWxEoUnaljbZ30s0+IqOwUswJR9LkT+K7wtg4GrpBoteCF86tKOl/Ia5Uovch 3rd3B3udv4QXb3xcQeaxhbg== X-Received: by 2002:a05:620a:3728:b0:93e:5a3f:ac13 with SMTP id af79cd13be357-93f29a0a71dmr1436767685a.0.1792413535157; Mon, 19 Oct 2026 05:38:55 -0700 (PDT) X-Received: by 2002:a05:620a:3728:b0:93e:5a3f:ac13 with SMTP id af79cd13be357-93f29a0a71dmr1436759185a.0.1792413534522; Mon, 19 Oct 2026 05:38:54 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c40919bcad6sm354612466b.52.2026.10.19.05.38.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 05:38:53 -0700 (PDT) Message-ID: <577a1383-1198-484e-81cd-3de996cc7150@oss.qualcomm.com> Date: Mon, 19 Oct 2026 14:38:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] drm/msm/a6xx: Add a bandwidth table for the Adreno 620 GMU To: patches@brar.si, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261016-adreno-a620-v1-0-4a7ed6210d7d@brar.si> <20261016-adreno-a620-v1-2-4a7ed6210d7d@brar.si> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20261016-adreno-a620-v1-2-4a7ed6210d7d@brar.si> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE5MDA1MCBTYWx0ZWRfX0a+tvT1Az+Kv IVrrvo3o8OvCZojX4SPZCgrSDGvbuzOxT8Z1uA2bMuNAdS1x3jQoqMIrp3Nd7xd8pE8r47bUW79 N/nGOwp/xMRc0n4JS6WKGXxUrQoyBS8= X-Proofpoint-ORIG-GUID: ZqBnFq1foffIAJ1xVrN9gSdJtc_MAjNJ X-Proofpoint-GUID: ZqBnFq1foffIAJ1xVrN9gSdJtc_MAjNJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE5MDA1MCBTYWx0ZWRfXzgn7zBU+Ewci 0UknJti49ZmxhbmarUJvVYwltAxXknPX6YB3s+RtmGshegXW/T92JLxFO0PatLC53pBD6Bn6wg4 v0QMvEwnf9XqcGXPGMcmdDTC2SN+ODOY1t/0sSlCWLOSio9FMRWwNmWmhrrZHjEBN893vY2YEJo kzlBh1GH5KEi2zSnMdbCD39gFPYXmg4NtCJfCTpLdRnKN24EANSMwFIJaoEDnw1kRM6PiwMRdK9 b5U/ot9DuPjU0uGp++bb50/kPCjw0MRdvuCddl3Qft95BXLbopM4SojUGic7Wp53akwxtxzbwjw 0LGRq1Cv6PUTPKuaj4lKf8d0LXpXC+zddOPttIz0ZgWlYUKh6dJfO5nhXuylY1AaYSvIXRBzCe+ bjZ5orQr5jZ4jiN+T6LQNPufkSfq/uNdUb4+3g2zg7T03TvRDBiDwRp1wwAtC1rD6UCC/yrR1CY KrSFRxlPUP5CHn7/iZA== X-Authority-Analysis: v=2.4 cv=K6O3jCWI c=1 sm=1 tr=0 ts=6ad60f5f cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=ODsmY_3wxSbvKopP8XUA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-19_03,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610190050 On 10/16/26 2:53 PM, Ishu Brar via B4 Relay wrote: > From: Ishu Brar > > Without an A620 specific table the GMU falls back to the generic A630 > one, whose BCM addresses do not exist on SM7250, and the first GX > performance vote times out. > > Like the A650 one, send a single "off" entry just to get things running, > with the BCM addresses looked up in cmd-db. Add adreno_is_a620() for the > selection. > > Assisted-by: Claude > Signed-off-by: Ishu Brar > --- > drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 33 +++++++++++++++++++++++++++++++++ > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 +++++ > 2 files changed, 38 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c > index 6b34e704a..cab7ffc63 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c > @@ -553,6 +553,37 @@ static void a650_build_bw_table(struct a6xx_hfi_msg_bw_table *msg) > msg->cnoc_cmds_data[1][0] = 0x60000001; > } > > +static void a620_build_bw_table(struct a6xx_hfi_msg_bw_table *msg) This is no longer necessary if you add .bcms in the catalog, see a6xx_generate_bw_table() Konrad