From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757589AbcIPNys (ORCPT ); Fri, 16 Sep 2016 09:54:48 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38248 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752856AbcIPNyp (ORCPT ); Fri, 16 Sep 2016 09:54:45 -0400 Subject: Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELDADDR to fix sparse warnings To: Greg KH References: <2fdea4da0036cd13aa0879ffcf86e3303013d52a.1473821899.git.sironhide0null@gmail.com> <20160916075259.GB1858@kroah.com> <157cd71a-bce4-03f3-bc76-635f493c0051@gmail.com> <20160916125727.GC29701@kroah.com> Cc: liodot@gmail.com, charrer@alacritech.com, linux-kernel@vger.kernel.org From: zerons Message-ID: <577a2ed8-9a88-98d3-6b4f-13f6b690b21d@gmail.com> Date: Fri, 16 Sep 2016 21:54:36 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160916125727.GC29701@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/16/2016 08:57 PM, Greg KH wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > > http://daringfireball.net/2007/07/on_top > > On Fri, Sep 16, 2016 at 06:41:38PM +0800, zerons wrote: >> these marcos are used to get the value or address of a member of a `__iomem` structure. >> GET_FIELDADDR is like &iomem_obj->field, and >> GET_FIELD32 is iomem_obj->u32val, GET_FIELD64 is iomem_obj->u64val. >> >> If patch the .c file directly, the source gets into a mess. > > But add the macro, and then use it, in the same patch, so we can verify > that this macro really is doing what you think it is doing, and so that > it is used at the same time (no need to add a macro that no one uses... > > thanks, > > greg k-h > Again, sorry about the `top-posting`. I am still not familiar with these things, thanks for reminding me, I will follow the rules and try my best not to waste your time. Ok, I will add the macro and use it to fix the warning in the same patch, and resend the patches.