mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>,
	linux-input@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver
Date: Tue, 20 Aug 2024 09:21:50 +0200	[thread overview]
Message-ID: <577e96df-5535-4530-ac62-edc53881a443@web.de> (raw)
In-Reply-To: <20240820002210.54014-3-stuart.a.hayhurst@gmail.com>

…
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,842 @@
…
> +enum {
> +	CORSAIR_VOID_BATTERY_NORMAL	= 1,
…
> +	CORSAIR_VOID_BATTERY_CHARGING	= 5,
> +};

Would you like to choose a corresponding name for such an enumeration?

Can any other data type be reused for this purpose?


…
> +static ssize_t send_alert_store(struct device *dev,
> +				struct device_attribute *attr,
> +				const char *buf, size_t count)
> +{
…
> +	if (ret < 0) {
> +		hid_warn(hid_dev, "failed to send alert request (reason: %d)",
> +			 ret);
> +	} else {
> +		ret = count;
> +	}

Would you like to omit curly brackets here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11-rc4#n197

Regards,
Markus

  reply	other threads:[~2024-08-20  7:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  0:22 Stuart Hayhurst
2024-08-20  7:21 ` Markus Elfring [this message]
2024-08-20 17:59   ` Stuart
2024-08-21  6:49     ` [v3] " Markus Elfring
2024-08-20  9:16 ` [PATCH v3] " Markus Elfring
2024-08-20 17:39   ` Stuart
2024-08-21  7:50 ` Christophe JAILLET
2024-08-21  8:05   ` [v3] " Markus Elfring
2024-08-22  1:03   ` [PATCH v3] " Stuart
2024-08-22  6:02     ` Christophe JAILLET
2024-08-22 15:14       ` Stuart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577e96df-5535-4530-ac62-edc53881a443@web.de \
    --to=markus.elfring@web.de \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stuart.a.hayhurst@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome