mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
	Daniel Borkmann <daniel@iogearbox.net>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
	syzbot <syzbot+8218a8a0ff60c19b8eae@syzkaller.appspotmail.com>,
	ast@kernel.org, christian@brauner.io, davem@davemloft.net,
	dsahern@gmail.com, hawk@kernel.org, idosch@mellanox.com,
	john.fastabend@gmail.com, kafai@fb.com, ktkhai@virtuozzo.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	petrm@mellanox.com, roopa@cumulusnetworks.com,
	songliubraving@fb.com, syzkaller-bugs@googlegroups.com,
	xdp-newbies@vger.kernel.org, yhs@fb.com
Subject: Re: INFO: task hung in rtnetlink_rcv_msg
Date: Mon, 25 Feb 2019 08:55:40 -0800	[thread overview]
Message-ID: <57807dca3bf554d0a07356ba1e53fae4d58cfb51.camel@perches.com> (raw)
In-Reply-To: <20190225093933.748ceab4@carbon>

On Mon, 2019-02-25 at 09:39 +0100, Jesper Dangaard Brouer wrote:
> On Sat, 23 Feb 2019 01:47:00 +0100
> Daniel Borkmann <daniel@iogearbox.net> wrote:
> 
> > On 02/22/2019 10:45 PM, Jakub Kicinski wrote:
> > > On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote:  
> > > > On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote:  
> > > > > Hi!
> > > > > 
> > > > > Seems like something funny is going on with get_maintainer.pl since XDP
> > > > > entry got added.  We seem to have been CCed on:    
> > > > 
> > > > I suggest removing the MAINTAINERS line with
> > > > 
> > > > 	K:	xdp
> > > > 
> > > > as xdp is a pretty generic file/patch content
> > > > regex match for the K: type
> > > > 
> > > > $ git grep --name-only xdp | wc -l
> > > > 236
> 
> I'm unsure how K: works, but you grep definitely selects some wrong files.
> 
> I tried with "xdp_":
>  git grep --name-only xdp_
> 
> That does catch all the driver that have XDP support, which is the
> point of the exercise (to catch drivers).
> 
> It does contain a couple of false-positives:
>   drivers/net/ethernet/neterion/vxge/vxge-traffic.c
>   drivers/thunderbolt/tb_msgs.h
>   drivers/thunderbolt/xdomain.c
>   sound/soc/codecs/rt5670.c
> 
> Via the pattern '[^a-z]xdp_' I'm only left with the thunderbolt
> false-positive, as it have a data struct's called tb_xdp_*.

Then it's probably better to use

K:	\Wxdp_

and if XDP_ is also to be matched, maybe

K:	(?i:\Wxdp_)


  reply	other threads:[~2019-02-25 16:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 17:00 syzbot
2019-02-22 20:01 ` Jakub Kicinski
2019-02-22 20:14   ` Joe Perches
2019-02-22 21:45     ` Jakub Kicinski
2019-02-23  0:47       ` Daniel Borkmann
2019-02-25  8:39         ` Jesper Dangaard Brouer
2019-02-25 16:55           ` Joe Perches [this message]
2019-02-25 19:26             ` Jesper Dangaard Brouer
2024-06-20 13:32 Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57807dca3bf554d0a07356ba1e53fae4d58cfb51.camel@perches.com \
    --to=joe@perches.com \
    --cc=ast@kernel.org \
    --cc=brouer@redhat.com \
    --cc=christian@brauner.io \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=hawk@kernel.org \
    --cc=idosch@mellanox.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=songliubraving@fb.com \
    --cc=syzbot+8218a8a0ff60c19b8eae@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=xdp-newbies@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®