From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932912AbcGLLLC (ORCPT ); Tue, 12 Jul 2016 07:11:02 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:50428 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752554AbcGLLLA (ORCPT ); Tue, 12 Jul 2016 07:11:00 -0400 Subject: Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time To: Sergei Shtylyov , "David S . Miller" , linux-ide@vger.kernel.org References: <1468321179-7647-1-git-send-email-colin.king@canonical.com> <034d8edb-439e-eafe-0743-4b69bf50b49e@cogentembedded.com> <80ace01e-b03e-39f8-a6fe-ad2f61079731@cogentembedded.com> Cc: linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <5784D01D.7070304@canonical.com> Date: Tue, 12 Jul 2016 12:10:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <80ace01e-b03e-39f8-a6fe-ad2f61079731@cogentembedded.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/16 12:09, Sergei Shtylyov wrote: > On 7/12/2016 2:04 PM, Sergei Shtylyov wrote: > >>> From: Colin Ian King >>> >>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43 >>> bits 11:8 specify the primary drive cmd_high_time, however, >>> currently just 3 bits of the 4 are being used because the mask >>> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock >>> to be detected. >>> >>> Also add in missing space between switch and parenthesis to clean >>> up a checkpatch warning. >>> >>> Signed-off-by: Colin Ian King >> >> Acked-by: Sergei Shtylyov > > BTW, drivers/ata/pata_hpt366.c has the same bug... OK, I'll fix that too in a moment. > > MBR, Sergei >