mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Chuhong Yuan <hslester96@gmail.com>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: go7007: fix a miss of snd_card_free
Date: Tue, 10 Dec 2019 12:48:33 +0100	[thread overview]
Message-ID: <57851e6b-4cd6-af1b-4b62-4db3b2673b8a@web.de> (raw)
In-Reply-To: <20191210031548.18659-1-hslester96@gmail.com>

> go7007_snd_init() misses a snd_card_free() in an error path.
> Add the missed call to fix it.

Can the tag “Reported-by” be appropriate according to a review comment
from 2017-09-19?
https://lkml.org/lkml/2017/9/19/115
https://lore.kernel.org/patchwork/comment/1026462/


> Changes in v2:
>   - Use goto to simplify the code.

Thanks for your improvement of the exception handling.

Regards,
Markus

      reply	other threads:[~2019-12-10 11:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10  3:15 Chuhong Yuan
2019-12-10 11:48 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57851e6b-4cd6-af1b-4b62-4db3b2673b8a@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@oracle.com \
    --cc=hslester96@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®