From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952AbcGMOQV (ORCPT ); Wed, 13 Jul 2016 10:16:21 -0400 Received: from bert.emutex.com ([91.103.1.109]:34591 "EHLO bert.emutex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbcGMOQE (ORCPT ); Wed, 13 Jul 2016 10:16:04 -0400 Subject: Re: [PATCH v2 0/3] Init device ids from ACPI of_compatible To: Crestez Dan Leonard , linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Jarkko Nikula , Mika Westerberg References: Cc: Len Brown , linux-i2c@vger.kernel.org, Wolfram Sang , linux-spi@vger.kernel.org, Mark Brown , linux-kernel@vger.kernel.org, Octavian Purdila From: "Dan O'Donovan" Message-ID: <57864D10.2020007@emutex.com> Date: Wed, 13 Jul 2016 15:15:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) X-Spam-Report: Spam detection software, running on the system "statler.emutex.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: On 07/13/2016 12:53 PM, Crestez Dan Leonard wrote: > When using devicetree stuff like i2c_client.name or spi_device.modalias > is initialized to the first DT compatible id with the vendor prefix > stripped. Since some drivers rely on this in order to differentiate between > hardware variants try to replicate it when using ACPI with DT ids. > > This also makes it so that the i2c_device_id parameter passed to probe is > non-NULL when matching with ACPI and DT ids. This solves a problem for me, thanks Leonard! For the series (in case it helps): [...] Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list 0.0 T_FILL_THIS_FORM_SHORT Fill in a short form with personal information Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2016 12:53 PM, Crestez Dan Leonard wrote: > When using devicetree stuff like i2c_client.name or spi_device.modalias > is initialized to the first DT compatible id with the vendor prefix > stripped. Since some drivers rely on this in order to differentiate between > hardware variants try to replicate it when using ACPI with DT ids. > > This also makes it so that the i2c_device_id parameter passed to probe is > non-NULL when matching with ACPI and DT ids. This solves a problem for me, thanks Leonard! For the series (in case it helps): Tested-by: Dan O'Donovan > > These patches are on top of linux-pm/linux-next. I delayed v2 until ACPI > overlays got in in order to avoid conflicts. I tested using ACPI overlays but > there is no actual dependency. This series just extends the PRP0001 feature to > be more useful for I2C/SPI. > > The patches only touches the ACPI-specific parts of the i2c and spi core. > > Here is an example .dsl for an SPI accelerometer connected to minnowboard max: > > Device (ACCL) > { > Name (_ADR, Zero) > Name (_HID, "PRP0001") > Name (_CID, "PRP0001") > Name (_UID, One) > > Method (_CRS, 0, Serialized) > { > Name (RBUF, ResourceTemplate () > { > SPISerialBus(1, PolarityLow, FourWireMode, 16, > ControllerInitiated, 1000000, ClockPolarityLow, > ClockPhaseFirst, "\\_SB.SPI1",) > GpioInt (Edge, ActiveHigh, Exclusive, PullDown, 0x0000, > "\\_SB.GPO2", 0x00, ResourceConsumer, , ) > { // Pin list > 1 > } > }) > Return (RBUF) > } > Name (_DSD, Package () > { > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () > { > Package () {"compatible", "st,lis3dh"}, > } > }) > } > > Link to v1: https://www.spinics.net/lists/linux-acpi/msg66469.html > Changes: > * Rebase on after acpi overlays got it. > * Change acpi_of_modalias outlen param to size_t > * Use {} after else > > Crestez Dan Leonard (3): > acpi: Export acpi_of_modalias equiv of of_modalias_node > acpi i2c: Initialize info.type from of_compatible > acpi spi: Initialize modalias from of_compatible > > drivers/acpi/bus.c | 36 ++++++++++++++++++++++++++++++++++++ > drivers/i2c/i2c-core.c | 8 +++++++- > drivers/spi/spi.c | 11 ++++++++++- > include/acpi/acpi_bus.h | 1 + > 4 files changed, 54 insertions(+), 2 deletions(-) >