From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbcGNILM (ORCPT ); Thu, 14 Jul 2016 04:11:12 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:64224 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbcGNILA (ORCPT ); Thu, 14 Jul 2016 04:11:00 -0400 X-AuditID: cbfec7f5-f792a6d000001302-3d-5787491021c0 Message-id: <5787490F.5000105@samsung.com> Date: Thu, 14 Jul 2016 10:10:55 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Ingo Molnar Cc: Anna-Maria Gleixner , LKML , Peter Zijlstra , Thomas Gleixner , rt@linutronix.de, Richard Cochran , Sebastian Andrzej Siewior , Linus Torvalds , Linus Walleij , Paul Gortmaker , Richard Purdie , linux-leds@vger.kernel.org Subject: Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine References: <20160713153219.128052238@linutronix.de> <20160713153336.465496902@linutronix.de> <57873CFF.1010803@samsung.com> <20160714074713.GA17287@gmail.com> In-reply-to: <20160714074713.GA17287@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4ZV0Bz/Zwg1WN6hbvLixns5h2cRKz xZQ/y5ksLu+aw2ax9c06RovV/04xWlzbe5zZ4njvASaL3q6dTBa7dz1ltbh65yCjxeZNU5kt HvW9ZXfg9di8Qstj06pONo871/awebw7d47d48SM3ywee+b/YPX4vEnOY/2WrUwBHFFcNimp OZllqUX6dglcGdtWrWUpOMdT0bfjKVsD4x/OLkZODgkBE4mzl3awQdhiEhfurQeyuTiEBJYy Sjyc38cC4TxjlNh17xszSBWvgJbEl38tYDaLgKrE0zkfWEBsNgFDiZ8vXjOB2KICERJ/Tu9j hagXlPgx+R5YjYiAksTiLx/ZQYYyC7xhlrjz4iYjSEJYIEBi2q0PUNsWM0q8WdAL1sEpoC/x c8YxMJtZwFpi5aRtjBC2vMTmNW+ZJzAKzEKyZBaSsllIyhYwMq9iFE0tTS4oTkrPNdIrTswt Ls1L10vOz93ECImhrzsYlx6zOsQowMGoxMP7IK8tXIg1say4MvcQowQHs5II7xL39nAh3pTE yqrUovz4otKc1OJDjNIcLErivDN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MPZITTrZxioUO8/O POO+vgWjWkTwhE0yiVMezHw3f6HAtknzt4vk/i24ut1xw7rwM5efXd5W6aL7axf//qC3feoX zE+cfSJzh9W51G9vx3ZJk52G9rWfNWfVMHJ0vmF/Vbukp3mqudQcs9KYktLouv5/GdXPZsYU 9Qf8efihiG2659Vvu+u3BymxFGckGmoxFxUnAgDiDUd3nQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/14/2016 09:47 AM, Ingo Molnar wrote: > > * Jacek Anaszewski wrote: > >>> @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) >>> } >>> >>> register_syscore_ops(&ledtrig_cpu_syscore_ops); >>> - register_cpu_notifier(&ledtrig_cpu_nb); >>> + >>> + /* >>> + * FIXME: Why needs this to happen in the interrupt disabled >>> + * low level bringup phase of a cpu? >>> + */ >> >> Why wasn't it possible to clarify the issue before the >> submission? > > Nothing has been applied yet (this submission is part of the clarification > process), are you fine with this conversion as-is, with a separate patch doing any > followup fixes - or would you prefer another approach? > > This CPU hotplug series tries to do straightforward conversions to the CPU hotplug > state machine without changing behavior - while pointing out any problems that > were found along the way. > > I agree that the addition of this FIXME should probably have been pointed out in > the changelog as well, but this patch was submitted once already with no feedback > received - and that's the historic pattern with such types of series: only a low > percentage of all driver maintainers replies so we have to be proactive to a > certain degree to have a chance of improving core kernel infrastructure. It's > better to add FIXMEs with open questions that to introduce subtle problems. Thanks for the explanation. I'm OK with that approach. Acked-by: Jacek Anaszewski -- Best regards, Jacek Anaszewski