On Wed, Jan 21, 2009 at 10:13 PM, Mikael Pettersson <mikpe@it.uu.se> wrote:

Impact: Cleanup.

Remove unneeded assignment to tsk in recent x86 change.

>  > Hm, I'm not sure I see the inconsistency here. Care to explain this
>  > inconsistency in a couple of words?
>
> You're initialising some variables in their declarations, and some
> using assignments at the start of the procedure body. In particular,
> for some reason you don't initialise 'mm' in its declaration even
> though you could do so for consistency with 'tsk'.
>
> However, I'm strongly in favour of separating declarations and
> initialisations (esp. ones that need actual computations), so
> rather than subjecting 'mm' to the treatment you gave 'tsk',
> just leave the code alone.
>

Patch v2 with the second hunk removed is attached to this message.

Thanks,
Uros.