From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932340AbcGOJBf (ORCPT ); Fri, 15 Jul 2016 05:01:35 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:36652 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932312AbcGOJB3 (ORCPT ); Fri, 15 Jul 2016 05:01:29 -0400 X-AuditID: cbfee68e-f79266d000001428-09-5788a6663904 Message-id: <5788A64C.4090901@samsung.com> Date: Fri, 15 Jul 2016 14:31:00 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2] ARM: dts: exynos: Properly select eMMC HighSpeed mode on Odroid XU References: <1468570369-14355-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1468570369-14355-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsWyRsSkTTdtWUe4wYJVwhYbZ6xntZh/5Byr xesXhhb9j18zW2x6fI3V4vKuOWwWM87vY3Jg99i0qpPNY/OSeo++LasYPT5vkgtgieKySUnN ySxLLdK3S+DKOLz0BlPBfr6K2z/VGxjfcncxcnBICJhIvHil0cXICWSKSVy4t56ti5GLQ0hg BaPEqZ2HmSESJhITWw4wQySWMkrsaL/FDuE8YJTo+3IUrIpXQEtifncbC4jNIqAqcfXdFjYQ m01AW+Lu9C1MINtEBSIkHl8QgigXlPgx+R4LyBwRgZuMEg1t/8DmMAtYSGzdupodxBYWiJF4 c2wX2EwhAXeJD81/wGZyCnhIHGzbzARRby2xctI2RghbXmLzmrdgl0oIHGOXaFs1ixHiIAGJ b5MPsUC8LCux6QDUZ5ISB1fcYJnAKDYLyU2zkIydhWTsAkbmVYyiqQXJBcVJ6UVGesWJucWl eel6yfm5mxiBcXb637O+HYw3D1gfYhTgYFTi4RU42h4uxJpYVlyZe4jRFOiKicxSosn5wGjO K4k3NDYzsjA1MTU2Mrc0UxLnTZD6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qBMbRMV07P l3ldvbVu42kug4jM526qt9KZ/txr/98hOenKgb/cS3YwXJB2U665LHNS29zGRXi5+aOn+h/2 Zne6Ma846c2dU6PCoi/n9oklX/V7y8Y4izcrOz58Pfz/Vtz/1dekwl7e/Lc+z2Ld75fnMto8 9wU1SJXld4iybPLzbTjr0dS7T0hRiaU4I9FQi7moOBEAOLWMv64CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jAd20ZR3hBn1NfBYbZ6xntZh/5Byr xesXhhb9j18zW2x6fI3V4vKuOWwWM87vY3Jg99i0qpPNY/OSeo++LasYPT5vkgtgiWpgtMlI TUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBOkBJoSwxpxQo FJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHF46Q2mgv18Fbd/qjcwvuXuYuTkkBAw kZjYcoAZwhaTuHBvPVsXIxeHkMBSRokd7bfYIZwHjBJ9X46CVfEKaEnM725jAbFZBFQlrr7b wgZiswloS9ydvoWpi5GDQ1QgQuLxBSGIckGJH5PvsYDMERG4ySjR0PYPbA6zgIXE1q2r2UFs YYEYiTfHdoHNFBJwl/jQ/AdsJqeAh8TBts1MEPXWEisnbWOEsOUlNq95yzyBUWAWkh2zkJTN QlK2gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZwND+T3sF4eJf7IUYBDkYlHl4G 345wIdbEsuLK3EOMEhzMSiK8bkuBQrwpiZVVqUX58UWlOanFhxhNgYEwkVlKNDkfmGjySuIN jU3MjCyNzCyMTMzNlcR5H/9fFyYkkJ5YkpqdmlqQWgTTx8TBKdXAuKGKOfIZqwFHY7K44Zf6 vPelRrkl51Ty9Gd9SLjo+P/Sqf4vt3M1f5wJNxEJY07pPu/BzrNhbeWrFT0Xb/BphvYo5C06 cfTubdcGsyed7BtK1yZOW7k783fBtok2LC4HuOz2Xfqn+03rIY+sjrWtAadjLNOfb9L7//uq 7AtwLA38dq91jcYZJZbijERDLeai4kQAHLfrifwCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 01:42 PM, Krzysztof Kozlowski wrote: > Exynos5410 supports eMMC version 4.41 so HS200 is the top mode which > should be configured. This is reflected in usage of > "samsung,exynos5250-dw-mshc" compatible. However Odroid XU DTS > contained also property "mmc-hs400-1_8v" which is parsed by MMC core > therefore resulting in mixed configuration. MMC core set HS400 but > dwmmc_exynos driver did not configure the data strobe for HS400 DDR > mode. > > Removal of HS400 properties fixes semi-random mmc errors during boot: > mmc_host mmc0: Bus speed (slot 0) = 400000000Hz (slot req 200000000Hz, actual 200000000HZ div = 1) > mmc0: mmc_select_hs400 failed, error -84 > mmc0: error -84 whilst initialising MMC card > > Signed-off-by: Krzysztof Kozlowski > Looks good, thanks. Reviewed-by: Alim Akhtar > --- > > Changes since v1: > 1. Remove also samsung,read-strobe-delay, suggested by Alim Akhtar. > --- > arch/arm/boot/dts/exynos5410-odroidxu.dts | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts > index d9499310a301..f6d135245a4b 100644 > --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts > +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts > @@ -447,14 +447,11 @@ > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; > samsung,dw-mshc-ddr-timing = <0 2>; > - samsung,dw-mshc-hs400-timing = <0 2>; > - samsung,read-strobe-delay = <90>; > pinctrl-names = "default"; > pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd>; > bus-width = <8>; > cap-mmc-highspeed; > mmc-hs200-1_8v; > - mmc-hs400-1_8v; > vmmc-supply = <&ldo20_reg>; > vqmmc-supply = <&ldo11_reg>; > }; >