mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>, Borislav Petkov <bp@alien8.de>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v2 2/2] x86/CPU/AMD: Print the reason for the last reset
Date: Tue, 8 Apr 2025 13:34:30 -0500	[thread overview]
Message-ID: <5788aca2-2565-4c7d-9760-6a08509eb014@kernel.org> (raw)
In-Reply-To: <9be828dc-94d0-4760-a78f-e8f92d92bcbd@intel.com>

On 4/8/2025 1:28 PM, Dave Hansen wrote:
> On 4/8/25 11:19, Mario Limonciello wrote:
>> I think it's still valuable to have it in documentation for anyone who
>> wants to read more about this.  As we get issues that come out of the
>> woodwork I could see people punching the string into a search engine and
>> then being spit at debugging.rst and we can adjust documentation to tell
>> them what to do with it when it's not clear.
> 
> How would that work when the documentation:
> 
>> +31, Internal, SW sync flood event
> 
> and the string don't match:
> 
>> +	if (value & BIT(31))
>> +		return "software sync flood event";
> 
> ?

Good catch.

If we're in agreement in the value of having the strings in the kernel 
and then also in this table I'll make sure both sets of strings are the 
same.


  reply	other threads:[~2025-04-08 18:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 17:47 [PATCH v2 1/2] Documentation: Add AMD Zen debugging document Mario Limonciello
2025-04-08 17:47 ` [PATCH v2 2/2] x86/CPU/AMD: Print the reason for the last reset Mario Limonciello
2025-04-08 18:14   ` Borislav Petkov
2025-04-08 18:19     ` Mario Limonciello
2025-04-08 18:28       ` Dave Hansen
2025-04-08 18:34         ` Mario Limonciello [this message]
2025-04-08 19:00       ` Borislav Petkov
2025-04-08 20:31   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5788aca2-2565-4c7d-9760-6a08509eb014@kernel.org \
    --to=superm1@kernel.org \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®