From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754134AbcGTN3g (ORCPT ); Wed, 20 Jul 2016 09:29:36 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:36849 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbcGTN3a (ORCPT ); Wed, 20 Jul 2016 09:29:30 -0400 Subject: Re: [PATCH] hwmon: ftsteutates: add watchdog dependency To: Arnd Bergmann , Jean Delvare References: <20160720103809.2643157-1-arnd@arndb.de> Cc: Thilo Cestonaro , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <578F7CB5.80803@roeck-us.net> Date: Wed, 20 Jul 2016 06:29:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160720103809.2643157-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2016 03:37 AM, Arnd Bergmann wrote: > The newly added fts "Teutates" hwmon chip contains a watchdog but fails > to link when the watchdog subsystem is disabled: > > drivers/hwmon/built-in.o: In function `fts_remove': > :(.text+0x161d8): undefined reference to `watchdog_unregister_device' > drivers/hwmon/built-in.o: In function `fts_probe': > :(.text+0x16cb4): undefined reference to `watchdog_register_device' > > This adds a Kconfig dependency in the same way that the other > similar drivers have. > > Signed-off-by: Arnd Bergmann > Fixes: ec9268ba1a96 ("hwmon: Add driver for FTS BMC chip "Teutates"") Thanks - folded into original patch. Guenter > --- > drivers/hwmon/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 15479eb15fa2..eaf2f916d48c 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -488,7 +488,8 @@ config SENSORS_FSCHMD > > config SENSORS_FTSTEUTATES > tristate "Fujitsu Technology Solutions sensor chip Teutates" > - depends on I2C > + depends on I2C && WATCHDOG > + select WATCHDOG_CORE > help > If you say yes here you get support for the Fujitsu Technology > Solutions (FTS) sensor chip "Teutates" including support for >