From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF5A3823B8; Wed, 7 Feb 2024 17:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707326798; cv=none; b=SkQr1rceGvGV8Q1I0FMlg+ZNEgRfGRB7iKDnn8zprFbWrDH2uERahGhyw+IXcbVvdH91r5MwHhYBXJVWL1PLoHsp4aF7zCVEfCWD5wc0O7RLiCAU1akOGgcaH63A9LS43cWSlxEkY5gVtNqjekrLbeGXXwI9BZydq5vp8KDN+ww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707326798; c=relaxed/simple; bh=WJY7bRLc+6QBXlwk3j67JAGs1qGHaeAeWvs21rNTsDA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=N67ZQLI3VDPaFFTr1TN8+HaqVl9+xfsNeU/snWwxrNWIAKBV7gckZKpNRqmH2NAcoJVvk8BhJj3K/4zdexrZlZJOein0i0Buwapu25B1KT7LFJX8Q9AWjyyHInz78Qv+EUlZBk2+0NnGKRapdPuM66YDxBKiZ5kM0ppfqT7+yrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=E8m1HfsY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="E8m1HfsY" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 417GLQ13005974; Wed, 7 Feb 2024 17:26:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=IeY4ENqyM6DquNVGtOMdp371wYPINtiRe/4HRffDQ3c=; b=E8 m1HfsYNKB2wq3CjI6Xms8FjgW0KXlqJOdYl4rgYruitZFj3M6oiogwYWUPvjDVkg zlUqEeI0XoZx5bf0KWFsI8g68K8tBvZMD3Lc29st+AjqB97OZuCMe2QGoyFNMD8r zD0Xiam9xysQpJ6rqbLo35Ufpzae1xcdhmvm/U4CKCp4vYUoOotz+94RH2E8tWZE rIR7DEi7k69ehWuqfm6QJ5A+d/aapIObr6X0JR4CAFYb4Mg6ZCugviZv4dySBdKO KbbLNp03L2IVtlrQqkh3mRwIuHEatsDkryXQF2+VWqnu75hI3WR6rEgWMt1s47CW CqFnw9mmsHwy7eDaOGug== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w4021ssgh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Feb 2024 17:26:16 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 417HQ90x030684 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Feb 2024 17:26:10 GMT Received: from [10.110.62.200] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 7 Feb 2024 09:26:06 -0800 Message-ID: <578b6a6e-83df-4113-9c1f-cdd7aa65f65e@quicinc.com> Date: Wed, 7 Feb 2024 09:26:05 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net: stmmac: dwmac-qcom-ethqos: Enable TBS on all queues but 0 Content-Language: en-US To: Abhishek Chauhan , Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S. Miller" , "Eric Dumazet" , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Jose Abreu , Maxime Coquelin , , , , , , Prasad Sodagudi , Andrew Halaney , Rob Herring CC: References: <20240207001036.1333450-1-quic_abchauha@quicinc.com> From: Jeff Johnson In-Reply-To: <20240207001036.1333450-1-quic_abchauha@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Ujof3VBVxrMBwZfiN1GFhhbJXa7VDHpK X-Proofpoint-GUID: Ujof3VBVxrMBwZfiN1GFhhbJXa7VDHpK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-07_09,2024-02-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=1 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 spamscore=1 clxscore=1011 adultscore=0 mlxlogscore=212 mlxscore=1 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402070129 On 2/6/2024 4:10 PM, Abhishek Chauhan wrote: > TSO and TBS cannot co-exist. TBS requires special descriptor to be > allocated at bootup. Initialising Tx queues at probe to support > TSO and TBS can help in allocating those resources at bootup. > > TX queues with TBS can support etf qdisc hw offload. > > This is similar to the patch raised by NXP <3b12ec8f618e> > <"net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings"> note that there is a standard way to refer to a prior patch, in your case: 3b12ec8f618e ("net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings") (note this format is defined in the context of the Fixes tag at ) /jeff