From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921543D3321 for ; Tue, 3 Mar 2026 11:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772536475; cv=none; b=ed7soORn+lS0nEGhREwqEUq0qVHwVtR0ilH5z2+phM6Dx6oc7NvzjEf6EcsDKXPAarSzLFbIhC1LJs121Wm/l/lnHr0HrEd5Zzx1Jw3PbkLrDUshPTPl43TncCL8zkGqNWqlMhJ7XeDTapV0P/uYhBrI5ssmU+yEjP96VHaICbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772536475; c=relaxed/simple; bh=YljFmeR70WqQRaMHHfK++kC2Lk5xogrFcPw5Bu9rtLw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sk71UbbzpSBPhmqBTF6IzvtqMASjaUVwKS4e+8VmqqdFnSOKVb9VxwCSFSVBqMjVVvEo4HR9BKXwwgjKUJmmdMW9ypg5ahlTj39kLv6tlfFH+TDQR8uNnAnYPqr86/pVUuj0neX1ktbQ7quRuiGn01Cch2lzKl9JF8o+EMJR6F8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d55Q8jtG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AjuhsVj9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d55Q8jtG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AjuhsVj9" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6239muho2773838 for ; Tue, 3 Mar 2026 11:14:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r+Ehs/Uhi5NZO8CagwJStesS/5PmHPBsRm/ob87Fnvg=; b=d55Q8jtG8vdFCXlD GY7hkGNE3XZkVoNu/HOJ8dSJ1GUCXoszztPDv+ZB8lzLL90a5s5GSkG0y+bkVPmA SAKIZjbhdHP63jaa0+jJRRUvCITEKGM3w8PgfhJpgtS+ax6+C8luyOGIP3LrFuqa o0/4JJ6Y8ZC5SJkbx6LOcQGk/0TbJBy2jxSgdWgvgE4p6RMx0H1N6M15KK9AIUV9 L0EEMeetb83qTbNNt5rYVnMVPYclqOXtAoP/pTozzMQRtR4kgR2wDuZt8yTbivuV s6Etk14zeKjnZ1ovO9HI3yDO7G4oyeDHSDolPb5rMHjCxCiKRaagE6AshB4yooW4 KF9ooQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cnsjm162s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Mar 2026 11:14:33 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c710279d57so453059685a.3 for ; Tue, 03 Mar 2026 03:14:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772536473; x=1773141273; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r+Ehs/Uhi5NZO8CagwJStesS/5PmHPBsRm/ob87Fnvg=; b=AjuhsVj9/dbIfrAvGSQ1rNPwSAPjyvhd6cWlbQJuugAHDbjTiEOFMTvwhvZtEdSmYF WqI96xX4MK9aeptNEXhtaBGmLG/s9ta6mfOllO9i7lZ0VrGiNwP2DYYNI8EvSaQP1Ohs gVwOyb9dvg1oPwMIyc7/j3GmanJBcusf4nMvvKfdfer4TYtymigpBxXiyCy/RC8rlpeX ISgF0KYVSa4aXVsPFn3MoyBjMrX1kRYwORkuCN8NT6TvJbemKizoFaSiMwbCfm1tZeVe 0JURi8W5TY8d6Z6hRHH6URlcML0xugoKtw7te9XSnt5R25P4uufe5Sub3TU+RWpxKsdl yM/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772536473; x=1773141273; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r+Ehs/Uhi5NZO8CagwJStesS/5PmHPBsRm/ob87Fnvg=; b=I30uoH7lELxtVIFVi2Wx7gs5LM6rTOnQaSOpz3PRAOz3tZGYcfLgIXUQAMCVTYpf2I G4Aofl7r3A14iL3pTzUC7fShAilwT5NThbYoKvi3mjsDM2MUqNYHhJAHiwS0b/MWtzYB QImxmqgiTRLdfg9cITm4O/LU2TRIy5f4q+ewuGsr9NaDE9Kr5G+vXdURoY6EwKJc1oV8 8z0LywupU1l4/ONt2yFOuf7o5W6KLz7YCUx8MCpd8gYjNXj1MbvpL7rc7Pzh5l+q801z FuwmAQ9Pluiul5b8IePwOwRgyRFsd9M/3nCg4FdEX5bmb244J9NkbMOqtTs1VtdWuram 3R3w== X-Forwarded-Encrypted: i=1; AJvYcCXV18lv5V2rOmBP5kEbIN5SiAgBhUA7SrKBaD2FSnLFO7vmu9D9BZHFZ6dLMsKPwG5004+swICJiECnMPA=@vger.kernel.org X-Gm-Message-State: AOJu0YwhEJjGWttI3XtGyzjeYxUNMu5B7jLp7TkbG62s8m6N8ROG0bU/ 2yoSEvO/sqekB+4YcfEQZYkx5U0HUayIR/Rs75t/AqsFE/JaMf0XMEV7NGyjGnSZ7U9GRVwneqf 9i94tj41pHcEbq3l7KVnXZyrlURcJHy59PZrq3e1PZsJ6jkHXzlfJ6jKf7mjxQe5CUaA= X-Gm-Gg: ATEYQzwVyUUDsnzm43uJdLelnKMA6CvoiAhScoj359PB+eGqWCWASloW+iq03yCn4NG VHk9c8Wyh9rYATpc2iMcci80CSLLjJKgZZncLzu3EHKz8Bxa0tnVQw4Rr+kfVWcEHSx3YL+aVc+ OM0Fz39F7Oe8DOfLYLLy3PwkRD8YHkRZUltJmA2/5iaaUCxiHC7cOLK3aDVT5MlQq4M+AS/6qD6 AicCKQWXJD+HvcrM1m02dj05AbFZS66d28Y0qgvOqgXgdoJ3ub2HkoZJ6mkuGAPK278qarnD0Xu l/Ce+nNGdq5+LKgIoE1SGrFMHrFbwuv0+DTS6Yn0/f4dODzFf4k0BTInPy3mqaguPo1M49x/UZx vHaj9+IwKBvYuYHkxMRVsy3t85a1k0WpFHSbAwFzyYr91hBaOtPAfVaUOeFqFKFWQh9I/QQgUr9 M9XHg= X-Received: by 2002:a05:620a:3945:b0:896:ead2:a657 with SMTP id af79cd13be357-8cbc8d9542amr1415724285a.0.1772536472446; Tue, 03 Mar 2026 03:14:32 -0800 (PST) X-Received: by 2002:a05:620a:3945:b0:896:ead2:a657 with SMTP id af79cd13be357-8cbc8d9542amr1415721585a.0.1772536472046; Tue, 03 Mar 2026 03:14:32 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935afe7d28sm564996566b.67.2026.03.03.03.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 03:14:31 -0800 (PST) Message-ID: <578c485e-b7d3-4468-bece-efeb6db2b1e1@oss.qualcomm.com> Date: Tue, 3 Mar 2026 12:14:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add vdda-refgen supply for Glymur To: Qiang Yu , Dmitry Baryshkov Cc: Krzysztof Kozlowski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260208-refgen-v1-0-87ca84fd78b3@oss.qualcomm.com> <20260208-refgen-v1-1-87ca84fd78b3@oss.qualcomm.com> <20260209-magic-conscious-seahorse-b81c8b@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: VULJPmuerdr6VPYPaV5UPDi3AjlzI6cD X-Authority-Analysis: v=2.4 cv=GIUF0+NK c=1 sm=1 tr=0 ts=69a6c299 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pnqVCfKAX2tXTj2rVogA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: VULJPmuerdr6VPYPaV5UPDi3AjlzI6cD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDA4NiBTYWx0ZWRfX36czNqmzWrYJ VhS89wXtTu8oJJvyEMdxE0yQk8V6MMOl9bPclY8MrD8JHBasVCLuREyTfp+uu+h9nbDylHMnFSr 1KgGiDLdTZbud3qdZn7JYyESfG0UohbMGmjcRgQeQLflfccsCoZjb9K9SoWSrpFgmPoO0pD0KGJ +eWGbYVH5of9ewxwIiga3y//aflpX8w1RcSEI8ewfu55bpcJNlj8U/1ZPW3z/vQUHLZ6AFQGMyA oG23S2KirQ+OIcvgQ6xLocIwhjlUgzhBILkuySUiveqF8eUMWVToYuikcl4AARhqT9BnfY2rEPv OlypzbwmDImTfPyvFWOFybxYtIcIrQTGT5g/V15RQ0NUUEmceXcW8JCHBYTtnzPizmga1AxDZzj XBMWogum0jDRoFUysSFj4oFMXcOuLMbQjgbKcy9YsNysEyIV89WTY0KF1i9PcAdtyrrkhWiPW7h l6PkyHXW3fOds0einQw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603030086 On 3/2/26 11:21 AM, Qiang Yu wrote: > On Fri, Feb 13, 2026 at 07:47:36PM +0200, Dmitry Baryshkov wrote: >> On Wed, Feb 11, 2026 at 07:32:23PM -0800, Qiang Yu wrote: >>> On Mon, Feb 09, 2026 at 09:06:23AM +0100, Krzysztof Kozlowski wrote: >>>> On Sun, Feb 08, 2026 at 08:49:39PM -0800, Qiang Yu wrote: >>>>> The PCIe QMP PHYs on Glymur require stable reference voltage provided by >>>>> refgen. The refgen itself requires two separate power supplies: >>>>> vdda-refgen0p9 and vdda-refgen1p2. >>>>> >>>>> Since there is no dedicated driver for REFGEN, add vdda-refgen0p9-supply >>>> >>>> How does the driver matter for the bindings? If I add dedicated driver >>>> for refgen, then I change the bindings? >>> >>> Yeah, I know that dt-bindings should describe hardware, not software. But >>> what I meant to say is that the refgen is different from qref which is >>> controlled via TCSR registers and its LDOs are requested to vote in >>> tcsrcc driver. The refgen doesn't required register setting and it doesn't >>> have dedicated driver, so we vote its LDOs in phy driver. I will avoid >>> this statement in next version. >> >> I must admit, I could not find references to the refgen in any of Glymur >> PCIe-related HPGs. >> >>> >>>> >>>> There is qcom,sc8280xp-refgen-regulator so why there cannot be >>>> qcom,x1e-refgen-regulator? >>> >>> I think we can and it seems better because the refgen for pcie phy also >>> supplies reference voltage to other modules like usb. But I checked the >>> qcom-refgen-regulator.c, it contains some register settings and there is >>> no LDOs voting. I'm not sure what does those register do, maybe Konrad >>> can provide some backgroud. >> >> Those regs provide voting for refgen, because on those platforms DSI >> block doesn't have a hardware vote for refgen. > > Hi Konrad, Dmitry > > I tried to model the reference voltage as a fixed regulator but the fixed > regulator driver only supports a single vin-supply. However, the refgen > block requires two separate power supplies (1.2V and 0.9V LDOs). > > Would it be appropriate to modify the qcom-refgen-regulator.c driver to > handle LDO voting for both the 1.2V and 0.9V supplies? In the regulator's > enable/disable callbacks, we could vote for and unvote these two LDOs > instead of performing register operations. Wait, so you want to associate the MMIO-controlled refgen's driver with a dummy regulator that takes 2 supplies? I didn't catch that part earlier, that's not great.. Or do we actually have access to the MMIO of *this* refgen and can control it (except we don't do that today because X Y Z)? Konrad