From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christophe Roullier <christophe.roullier@foss.st.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Richard Cochran <richardcochran@gmail.com>,
Jose Abreu <joabreu@synopsys.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32
Date: Fri, 8 Mar 2024 09:28:57 +0100 [thread overview]
Message-ID: <578f421c-ca06-45d4-8380-8b2b423d4d47@linaro.org> (raw)
In-Reply-To: <20240307135957.303481-3-christophe.roullier@foss.st.com>
On 07/03/2024 14:59, Christophe Roullier wrote:
> Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz
> This property can be used with RMII phy without cristal 50Mhz and when we
> want to select RCC clock instead of ETH_REF_CLK
> Can be used also with RGMII phy with no cristal and we select RCC clock
> instead of ETH_CLK125
>
Nothing improved here. You say you add new property (wrote it explicitly
in the subject), but where is it? Where is the user?
I think we talked about this. Rob also asked quite clear:
>That is obvious from the diff. What is not obvious is why we need a new
> property and what is the problem with the existing ones.
How did you solve it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-08 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 13:59 [PATCH v2 0/2] Add properties in dwmac-stm32 documentation Christophe Roullier
2024-03-07 13:59 ` [PATCH v2 1/2] dt-bindings: net: add phy-supply property for stm32 Christophe Roullier
2024-03-07 13:59 ` [PATCH v2 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation " Christophe Roullier
2024-03-08 8:28 ` Krzysztof Kozlowski [this message]
[not found] ` <50ee6122-b160-48ea-8c44-1046b5907d7c@foss.st.com>
2024-03-13 13:06 ` Krzysztof Kozlowski
2024-03-14 15:10 ` Christophe ROULLIER
2024-03-14 15:25 ` Krzysztof Kozlowski
2024-03-15 15:14 ` Christophe ROULLIER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578f421c-ca06-45d4-8380-8b2b423d4d47@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®