From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751373AbdAWPaW (ORCPT ); Mon, 23 Jan 2017 10:30:22 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:52179 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdAWPaU (ORCPT ); Mon, 23 Jan 2017 10:30:20 -0500 Subject: Re: [PATCH] block: Initialize cfqq->ioprio_class in cfq_get_queue() To: Alexander Potapenko , , , References: <20170123140643.32805-1-glider@google.com> CC: , From: Jens Axboe Message-ID: <5792bbb6-04e7-d3b2-b5cf-af628f4cac16@fb.com> Date: Mon, 23 Jan 2017 08:30:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170123140643.32805-1-glider@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CY1PR18CA0026.namprd18.prod.outlook.com (10.163.31.36) To BN6PR15MB1186.namprd15.prod.outlook.com (10.172.205.140) X-MS-Office365-Filtering-Correlation-Id: 024283f6-7fbb-4523-bbc0-08d443a4bb7b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1186; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;3:/0QfGVf5gIT2eBF4ju+CqbzziAOlOweAMD7W0cm2UEuDviR7tWvL+isdbcC3ufxHph02QzgdpIP9tAvc31UFA5SXsomzKy769bLUbR2UCVkgAYGiawEQUxKE/eTo1oZbynGdsraakPzh8GiA0cYK+4atvnomQ73PtD/hs0kRgBKJfbBrytX21+nz0Y7zEWtByWxvjdobwg0HkzKORtySkVK9Uh0zncLACQlZY/ASz5j2Pscj4SUGsiLXB+2SdwOqpFfcvch8o1s0YhxVuW0HFQ== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;25:Uk8BgYFFTHMjxvQ3RA1dU/o3FJ3tV889Xzf52qOLUcKf1Nlf2RjTmZiw+LAaPenKK3EQB5oyubDWzHL4BMnNrN98lqZ/D23MWH3uH4wyz6kvKRwrrcL9j7s5L2aGBpTCgmRbJaeKfsoAEc0TwuCPeXrANB6tK4SnGEJKCgGgpPr9BRRwkE86MYjLXbb289+zaa5UcRwirLPFRvlk2eNhjInP8fgMjzl2YPPZPsZ/Ln2ft6XyuDbkfkl1vfprhRBfLtGtuKXhIkRbMAidC6lDAFAoEAGKEfWKUJgrZSb8z2PFh0mmOegqKTuJ46V7Ahkgznt1O5zxkMh3NKawR3owYBfwL2flkEcsNnmilnTKqjjZbJB65e46VMDibrz7ZICMR09AO8ZwoHqjO0UCsHnrZ/Jl8i3cBKez6i9WWlsrAvnDw6yW/aPUiz8qK0lYpbjepnbO4HJ+hsZ+GKq/cSd4rEoCNiUwOV9+PNHH+2uZ/aplkcYzrqld2r5Ks/XnmOpY81lQ5u3Vb5HZixsaCQQF1ieGwvU8L+e9GguMqWIOVKxP4IS9dxBwrIsNmaU8y42xrgQB5XIhzQU2JSs5RuBVtIOGoKML2PdOo3iNp8Djj7D788iCa5VEQ1At6YVcrtpUYt2RCk5pGAJqG3b6suOYsXVPsRpTmiNw359i3zjaxbxi6SSgmY+V+jSRwwC8N1Q4e4Af8iamplAFXtvgcJ3Nzis+UDguMqbW8kjCnwMnKMbLdwxHZICyYlqoFX4NESW/aBIDhKeZLLOA7hEp5+6LSA== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;31:avpml0z/O1ymJvYN8MnrbH+nhZGeUGeBPpZpn4M6Vq6Zzb46qwL89BORnoa+8oipBuxUqJL5K3I/umzhXH3w4VjMwukLMZatVkof6rdeJeABOMbhtJF+RI6KVZSiaeXUA0pMEybtBMI+4pjxaXRsAyWtuYhSVTjPSDWyNyj+Bt9No4S3462ksgussQBJLz5oBf8MvlL7C77kqq+Klmo9eNZFvB0ulO4hHtMNnB/VqyNezCkD/+4kkLOvXgt/ncDQtXlgMKlGkrhgi9a8TrU+EA==;20:aBEg6IwWaOjLX6yVuxYUAUGd6ujpzZdpAVAuJC+xZZBGw9A+giCGI6O3uEQGZz4ImlsOZ1yw9/nQtLE39JL5ym6IlkuXgOLSB/szkK3AL8Ir+xwHRG5zs2CHZmCpcIk+5ZLe2mkcF9RzWJPbhHjNdNjGTxEjjAHFX0twAqrVlB7faNmrClKXxxe4I05Ap8EGu0UepmjeqxVC0yGHZ0EMR7bHMYsJEj87aX0Q7YnJ4Qnljif9lRuNl14kaLFGJ4jHrEMGz9Yax0TiDJuqSFf/qHd9DhnyEAcprizs6mR/OcVAgWcUX5Qqwc8Z9G9AZDvJCfw5OwrFuR43r9DyAGsKKFmoh9Tg1CZwBXUV6r8REcDOh+DigJi4P+xfV/UfCxYJYV2RuCzUljsrYfMMkAnfKLySyUEb/VfacDnYKg1LxT313ltu2RPNSt5yJXocPfTVXF+qs8g418WoI5qkXRKKo/Gu3tn0n551k6HjTplGmXkJszi3KP/P2l8uK2+5igAo X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:BN6PR15MB1186;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1186; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;4:5wT/kBCVUJTQeBqkGCxELH1DojivnlmDgz1YFaJZaiC5NYBXjevkgPP55GOfKW0Eih2GOr3BqfswpBfYSvXWzT6wjzFpa7EY2kxz2lnXN0Xeym2WD9m4U6/rN2Xam897KmWybd88z/fDxj21Ekuq94x41G8ucYXjHKJ8tRBsVY9YwUA8Ncte53Z8/O205yjGohPicvw/LqBBvFwNudcToWjXbfJB0R4QIPN0JM+rEJKEr2Z8Z5ThNnv7Nh6I3c031sjZpDXNwXhjz+Due+7tfm5AXPQrNyReCcKQzUl9ZgF3+V1Tpkruz3IBSrUcXv8Kg7bRwQBUx5xgIWRDStUX+dgqt5MBGHOGnimycGaPjkDNguHpj/k5aonaGGNy6FT4byn/gb589t4sUaFsIFb/mk4luVfarVJI1N2tyifH0ntQtFmE67V/3o8zzqeCtoBru9mqSLqlwwTrhWMENj5UeeNm9u48iFGaYCKV2UWbl/hbgwdFSM6RRRZH2Rnotzipli83R1UjPiaZPcHNIQxsUJ+SF8Irlq3+mhDC3Mr6PznVMSGuzi2x7tMFdSswMGyoWmKTlsrQJiVNaAzyZgjWLbRcUjfW5OD1SsuafkS53iCytN0nUCKmSGWjc29mg72e X-Forefront-PRVS: 0196A226D1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(39830400002)(39410400002)(24454002)(189002)(199003)(377454003)(31686004)(65826007)(230700001)(101416001)(5660300001)(7736002)(305945005)(42186005)(106356001)(105586002)(33646002)(92566002)(189998001)(54356999)(86362001)(575784001)(76176999)(47776003)(117156001)(68736007)(5001770100001)(31696002)(4001350100001)(2201001)(2950100002)(6666003)(50986999)(66066001)(65956001)(65806001)(97736004)(3846002)(6116002)(229853002)(38730400001)(83506001)(23746002)(2906002)(4326007)(36756003)(64126003)(8676002)(77096006)(53936002)(81156014)(81166006)(6486002)(90366009)(54906002)(50466002)(25786008);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1186;H:[192.168.1.154];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1186;23:R7UfKrfeAIO5D+BPUGkYsBX30DP3FyX0DtuDF?= =?Windows-1252?Q?KcG4q8jlxpcNd43kD8THOmsQSMgRKaM0mbXa6NrlZguFGNwTsKhKiy5L?= =?Windows-1252?Q?LgLiImrcLiZmPC56R6nFvFzDvrq80IKVaDhTFF2EWZjcRzjcHghp7tjG?= =?Windows-1252?Q?UB0WE9w/eW7QJJqXZCZpeInop6nGVGOKLx/DOg8aujIyWrAnk1fclyXX?= =?Windows-1252?Q?1IWZ29SXfnCup3GmXQ+CmP4MTHCXGi/xdxwkCe3kDMveBwjee/jGdfeo?= =?Windows-1252?Q?1IGIWkdm8buy6KaWu8lyGt3qNmPym2RVcXvA7qD+UwX6uBUgu6dWuZSB?= =?Windows-1252?Q?MPxDAKM98Ig2CTeXtCRm9qj82ma5IfpA7Zub5yewmO3YeQCeZp0544a/?= =?Windows-1252?Q?btZokxbJRv1aOLV78z/kUXvc/DETQ4LaCdfvODI2dKo3f8hZ0hB1DckF?= =?Windows-1252?Q?BHqg4xljIrwLs6kXbh1clNZ7kZ3jhRT9V3KKDPliyhnyC5/7JnmXylzm?= =?Windows-1252?Q?IWJwMe4SR9irB/xDgSBDQbym2rIb+YwwqeoEHg5HyRGZ1hAZavwcrI5i?= =?Windows-1252?Q?HcH+RNBkuIM7Kc/L8TMM2FylBwVfRRYYcqEPRDS40WGIBJ7UM8nYrCXL?= =?Windows-1252?Q?UFOaz/x5tq7NmkthsXXJyZ7gscv4WUxSo114XYdaQgl/OSV2PK3iHhC+?= =?Windows-1252?Q?UswgeSjhiRlWSaeNt5mXk8rbVkSjVBI0LTqDOcy5DG0R2UcydDHqQ8FZ?= =?Windows-1252?Q?/G/DTQNpJ7HfNjWjYJgDFOj7BHw16RUCTRFTpCcCbX8lLqxlZAdPuaMP?= =?Windows-1252?Q?d/QSIE84SmRjRoKxvLOPVg7W0sAaKyQZfNmhQmyrLGwNF9iNwk3PAvGP?= =?Windows-1252?Q?rS4c1qYUtD07PpLlvFIambcPlXYC48GyPmfyDJAjO+e2aQpFpIk1AsC2?= =?Windows-1252?Q?78JjyfuAcPzCEWGGDIGDxbmQoTaF8KX8KCkRpqxbuWz4AwLp3j6waMYr?= =?Windows-1252?Q?vk0jEa39wkY8COrg4IwLZsY+jjZfTpU6f8yxFxMLN3wWpTr/ywcZEVED?= =?Windows-1252?Q?M9uMCQ1ak/SOQbfZPTEYKVxYAj+3eK5j5BkPREi3A8Kg0svv1VrkEm0i?= =?Windows-1252?Q?RPodgXjhGnCHGXZAQnWMxOZeOPlArmInwpItWGSp11aBNnyC2v2aswPO?= =?Windows-1252?Q?Tg2q/2VgxoQYPFHTQ2laoChe82AAY+mywCkiyR4n0SCRsQjC4OBciNnP?= =?Windows-1252?Q?wZ5j4CJPCSTts0wTq4CuZTWwda8bpKfmaZB8jEF9iVxCfll5kgHFi1/6?= =?Windows-1252?Q?HfQgXP5FJ7mpMGEQZD+XRns2gKBS3O5iO3s82yMEMrrkaCEE1TCG+emR?= =?Windows-1252?Q?t1MCnddMkGbs0pRZeyMeH16bbH/zuG7oIWbEeiVM6TThac27X+IKn3ql?= =?Windows-1252?Q?NOssIHMZUHjNchn2AV8dC0z6YVg+WgODJ96+O8qpxcT7pClqnaSbuCE9?= =?Windows-1252?Q?1bmUPk0pWrLKvnh1n8BmXxjIMUnbas8hEPYZW+32DPmf2uszqHhlAxcO?= =?Windows-1252?Q?7Pj+FkFXmc4bcXmzgXJ3AjblV5DIbtFeXhiP2dkCHvuABbjA/M4HxymY?= =?Windows-1252?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;6:8d4Q1/MhTcWZ1m9YaR/HkArOM9Kwsg2xhffJZgnkYqFerNSe/C8AWOfkAcrSqMQ6/S8NRx3kdVVdhFnCC7HTEMjqqHqxq2xxrD627URlaekGGFLXztmCQeHpk6lqlXQ7vPsf9AqAT/YH+Cn6+Qq9uINBxxLVHeS+OvedOyUY3OzKzJpDtyhb6vNCxmLzOvkLUYMzrP+QoXPf7s6hxZobVvjr94ziLtHmHShgGuupRGl37Tfq+CnDLvXCS91mLrjvpf9+mW4gHKLFvvNcIMj5WzGqxQOsD2kaw9RV+KJOXIXcaiVx8ZFyEInp2JBc8hOtLjm/Xu7RziV2xJBGyoOBxS6jNqo4BlhRNJlyiW35vdVldkWHkganvPi+kyj46+fh7gByzgH0KkG4gMy85w0c0rYsubtMdxm5V8OQsTGJVgI=;5:UYUuzvEOUEHxm4l+JVvMEmTFWMAicEP38cT8WQKgUtlzPTrOXwwy3DwLJlct/qdbTYR5kRBQiPK/MblFn3cJb47LCcdJwio8Uo71ZU1HmBIasemEV6ugF1QkbUADHR+2hVJD+fX+/+dNpDeuyJyzSg==;24:Sd7LdDPDNzpmG416JKQhjYzhkSJp0T+eRTrWLnG7xlq/e6Bo3Z9Jlln4rjPfTf5RWKNSL523Jb3kSCMyeT/Ysd/u7KYiUuXQt14n9yND3XI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1186;7:pDBb5xeu+VrCJIbtSpDTuaP1audoocovhSulkP5llTcWeHT5zWOMcHY1CHGT0DoEzVPBHOuzWt3IGCO05HGjRCiadtofrvf4YyW5nPqTTJvKoV01D2lkQwyxje3UIDxWt3grtbQZTt8MgvdYQRNIjk7Uo0br8D0xdrWPw/OafsenliHIHrW/G1VU8MTP/JRRQ9wpdJQ6Z6dyuHE3DCBAozqCa4wJsz1XpZ1+km07rNrBKjpP+s45LSL7u/drunpGdQkNEsbgDBlUuDWBtU9LTmZVJN2R4350MC5JBcPypLBCZ6qy13fIxjLYj/psn34sVEPVKp93MVmyyNNgXBELgOPRcrE/s8FmDR40OCKutMlDstr4YQtBB9ItGnc9OuoREo0AfyxtcqOAGVqh01FtL90YbNRtmtJbAh3uRq27AEnlkVzNlp2Liu/+SbOaxJn3lm7cpNeCK6ckw++OwQ71fA==;20:qrIGIC10xlyGeDbcByVc9DggCPIABn9N83Kfby+1IqXURRnjio4AGrfpqzm7qvmivIa0/NEVQJ20fD2VcOg4zInYH/u5YXl3BA3t+TE7OcUQrbg4Ldd+9Zm5lRV0CSL7HYwYcJke/xU+JqmvBCLMGru2J48xHFhvHdjJBAypCX0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2017 15:30:15.8222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1186 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-23_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2017 07:06 AM, Alexander Potapenko wrote: > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in cfq_init_cfqq(): > > ================================================================== > BUG: KMSAN: use of unitialized memory > ... > Call Trace: > [< inline >] __dump_stack lib/dump_stack.c:15 > [] dump_stack+0x157/0x1d0 lib/dump_stack.c:51 > [] kmsan_report+0x205/0x360 ??:? > [] __msan_warning+0x5b/0xb0 ??:? > [< inline >] cfq_init_cfqq block/cfq-iosched.c:3754 > [] cfq_get_queue+0xc80/0x14d0 block/cfq-iosched.c:3857 > ... > origin: > [] save_stack_trace+0x27/0x50 arch/x86/kernel/stacktrace.c:67 > [] kmsan_internal_poison_shadow+0xab/0x150 ??:? > [] kmsan_poison_slab+0xbb/0x120 ??:? > [< inline >] allocate_slab mm/slub.c:1627 > [] new_slab+0x3af/0x4b0 mm/slub.c:1641 > [< inline >] new_slab_objects mm/slub.c:2407 > [] ___slab_alloc+0x323/0x4a0 mm/slub.c:2564 > [< inline >] __slab_alloc mm/slub.c:2606 > [< inline >] slab_alloc_node mm/slub.c:2669 > [] kmem_cache_alloc_node+0x1d2/0x1f0 mm/slub.c:2746 > [] cfq_get_queue+0x47d/0x14d0 block/cfq-iosched.c:3850 > ... > ================================================================== > (the line numbers are relative to 4.8-rc6, but the bug persists > upstream) > > The uninitialized struct cfq_queue is created by kmem_cache_alloc_node() > and then passed to cfq_init_cfqq(), which accesses cfqq->ioprio_class > before it's initialized. Patch looks fine to me, thanks. Is this a new warning? We don't seem to have changed this path in a while, yet I wonder why this is only surfacing now. -- Jens Axboe