From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 515A2393DE3 for ; Thu, 26 Feb 2026 08:39:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772095151; cv=none; b=sTcv1FdmD8DfMf2zNDpBBG4uSNborM1Kb0/L8yEnMHkNlpsgXWBqlCTlE5KUnpgTGKjj3fVgfenZBpgfVJM2AxPF3GXum2IkUvy9lDkTYyggxtJZCFDMViOcj5m7ZzkdNJ8LJV0cJk9CFV7P1COxRgFuVt2wxXfbg3ihQXgD1zU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772095151; c=relaxed/simple; bh=R6K4l/PiiRgIwLZgEKR8QRcOzf93V5Fy49QdAdUFsVY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rED/I7WJoLpwsYN+bYFY5Sw/VZ/i+yMBWsACcMcWbHMh9AxUjoViJZRZkKeshJ5VIxqZ0qr+8TGQZNZoeTTX+anXxQIAf8WEl5DhIMNuKnkcKgMm6a6P37s9oEo2scWKLnIDGZa77MhnGXdgDoVf2XhEH1UzOCkRzKnHwojMfJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dACNMrlA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f+2p4ZF0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dACNMrlA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f+2p4ZF0" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61Q4V8vQ918925 for ; Thu, 26 Feb 2026 08:39:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WAf2lFWJkeZZmog0R5l/0t54shFe/JIkci8HejhVV/E=; b=dACNMrlAA6SnWB49 /U85VgY6dPieg8kAp+l733U2BOVsVLzC5aQrlIxGE8UEudM88OioPpNx5wrxMOP2 7ZWCSxETgJVWKydVkTt7X5qrSbgCznrokCHzpN4OwFKYVoqyrVAq4oN5byRjPlAZ 9TkpwWmw3Z+y21kCyimkHbaUTq9/LQGV/skbMtdBxzugPg5dWcuWwERGdOxXFdHQ O125QlavaJMxj8YN4EYRCoDakbDKrqY8P50e0Y4B+o1bxODioicj65zZWMUqqZ6I zbF6PUGBHDKi47dBsvIQ7BdocAzXHJYsPwg84Kfy1Q2P+WpXPUomxQuzioz5Etnh VSseuQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cj4w4th7w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 08:39:08 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-824a2df507eso2087949b3a.2 for ; Thu, 26 Feb 2026 00:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772095147; x=1772699947; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WAf2lFWJkeZZmog0R5l/0t54shFe/JIkci8HejhVV/E=; b=f+2p4ZF0CGVLD0hsIvWHcK2PDK1/+1xeIqqT1ieF8XygyjP1yF/0ljaCBWOYA78EJB 37f7bm07SYI5lr9JKTBcuRkyocXx5NWSpyn/wiIXxoVvR3MFFBHHTcwp/TrcL/pbOOZk ZXx/bj4FcgYwSbqS/wrtI+vLOCW+4HcEhzgqVz0Q5ZG7QSLSfs2MfYuaiarLs5unD4lc TErHpudz7cFaQ/L8mkvPMYSC6fmeaIldw6pMdusV1cb97GcQiEqfE2xQuwh+3eOe8g2Z NkQVBMq3TLLFDCX7eyzqXIHTnQEHBRo372jubwlp38FKBeUO4ov/+0mYXmEYxITfgGMb ubpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772095147; x=1772699947; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WAf2lFWJkeZZmog0R5l/0t54shFe/JIkci8HejhVV/E=; b=vhxcQZpSSDgzE3YYV7B094mCR62e26zAcotEYtVAkunqqmGjiLqIiweHcTONQi1gfY 6ML9YsI42rMAHOL3OPwBxD2Ge2/oMqu7vHAOOB8vrxbo9xErm+y1qSnVhtsBIS0oOITP qQB9wXe9oWAK63lpcX4sjui0/AR5G/DpZbymHAuyxmPmTYKmwJO5dZ/12eeN8o644wpP ixfc28jrCvcYL/B2V3bfR+qF4JVSIiQr2oVEks3un/H3bZcFrSOTtErgtPuy5q7bKJkV 9DiXKmDU0vb95sr4GtJl2uP0lgAaIPs5Z1Quww0mrMhfWVU7kRQXglLRImuIIjMDT6vn F61A== X-Forwarded-Encrypted: i=1; AJvYcCWFUfLcV44qFlgkG/TSbciLse/aNzLoUubTl2RqOuwWmNK3NaXhNMW5wranaoLPIC/KWXD+3aOGx5ipy3c=@vger.kernel.org X-Gm-Message-State: AOJu0YxvTMi6k1SmWC2zGSNLyDRVwyJNwIta0ZTeBfNH4HGVIRDzHQfV Fdtwvuy0g7RIBXoW0+OozswncITouFj3NZSl8RAVtT8Rrh5f7XxXSKPLGkWI6MVA45kNNLsDhMg SMjHpi9kEO3GVWTt8DbeVYHEF2HaAnBoHtZObNHdZX5Iw/snloO+OmiUtewHFVlWE1Wo= X-Gm-Gg: ATEYQzz2giksmfMkqsNOwBODoM5MNoaed43rbgM3U72xEisbBB0c/cEDSX7+Pr4+j5Q O6yba6Fbdz2IYEJ9Gd7fqPyHWiR8fe7FGoFlW3pjxEwtR76bXthXjRJWIXbHRe4ZhtUgEtW6r09 SpueXEW0AJz+ci7phgBjPqEiwVYhPw4mottdMaywiyCp6xeHhunHy4VNa5l21LVaw8XtfPqJXOV DbiyODpvbSLSlcaB2HuG1x5BWlHgadaqmsDafWYFASYVCkkbTeyXdP7M1iFs63QRtAxA+CiKx6r TMqNYTYXCw5wbwRkOn0e5qVreeLUkOmtEV5RHKkOwJh4hPoA4L5bOzlQFhaoEgwqEFwyCh8j4jR yK9nadO2djtbOHe1rg9YYPJMkl0V9oeYNIWKibbm0cYudxY1LZw== X-Received: by 2002:a05:6a00:3d48:b0:823:1cc6:d60a with SMTP id d2e1a72fcca58-82733672a72mr3351020b3a.2.1772095146909; Thu, 26 Feb 2026 00:39:06 -0800 (PST) X-Received: by 2002:a05:6a00:3d48:b0:823:1cc6:d60a with SMTP id d2e1a72fcca58-82733672a72mr3350990b3a.2.1772095146324; Thu, 26 Feb 2026 00:39:06 -0800 (PST) Received: from [10.206.99.28] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a088517sm1538103b3a.65.2026.02.26.00.38.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Feb 2026 00:39:05 -0800 (PST) Message-ID: <57937a68-7f22-4ca1-8980-0be12cf06c66@oss.qualcomm.com> Date: Thu, 26 Feb 2026 14:08:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 05/18] accel/qda: Create compute CB devices on QDA compute bus To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Bharath Kumar , Chenna Kesava Raju References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-5-fe46a9c1a046@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: -PxYInk-GjQGuWmj7AI1hzdxP2P2ucMa X-Authority-Analysis: v=2.4 cv=IqMTsb/g c=1 sm=1 tr=0 ts=69a006ac cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=DUi5Cioa4Bt8-YlJvggA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDA3NyBTYWx0ZWRfXx3b4Wja8q3W7 QT1pa5gZSklR+nTF9dhpIpV2D3BhDLeOK/WSgRYXU74qukhq2AbyY6bAKXLvIq0wDbxafY99iSg PpRRmKwAnfXlwOuQT8Qo5IJV/zgDyS3cCOcPrG+2Kt1iwab92YFv/OLOAUeAV3P222Wq45jGF6B d4bWV1wFh0Nj8zCP4sPyzL1iJMCRWMPFRiF5sMJlcJV78gMmtePQKjmQd2zxJpGXyvtjC9Yk0TD 7tS7cqd8bndO7oI2UrPRk2rBUQ7WGyPy/Kc29Ay7/BHrlQpxz6zn4qgj8TMFbP7D9NWLBNimVeW VV2o6EdYp6q4lcmCyFpceJIWi7kVl5vs0TjvKm6L0W4sLTluksJ4AyiPApFaaaomHKB0GSHk98A xXr9KAOdTQCNGGga9XlKBB8dnAqVHEWqY3+K9mHt9qbzDiAiFnGkBH7X8L0M2hIbuOBu+h45vl0 YZC0Quppex6Tah3LDAQ== X-Proofpoint-GUID: -PxYInk-GjQGuWmj7AI1hzdxP2P2ucMa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260077 On 2/24/2026 4:19 AM, Dmitry Baryshkov wrote: > On Tue, Feb 24, 2026 at 12:38:59AM +0530, Ekansh Gupta wrote: >> Add support for creating compute context-bank (CB) devices under >> the QDA compute bus based on child nodes of the FastRPC RPMsg >> device tree node. Each DT child with compatible >> "qcom,fastrpc-compute-cb" is turned into a QDA-owned struct >> device on qda_cb_bus_type. >> >> A new qda_cb_dev structure and cb_devs list in qda_dev track these >> CB devices. qda_populate_child_devices() walks the DT children >> during QDA RPMsg probe, creates CB devices, configures their DMA >> and IOMMU settings using of_dma_configure(), and associates a SID >> from the "reg" property when present. >> >> On RPMsg remove, qda_unpopulate_child_devices() tears down all CB >> devices, removing them from their IOMMU groups if present and >> unregistering the devices. This prepares the ground for using CB >> devices as IOMMU endpoints for DSP compute workloads in later >> patches. > Are we loosing the nsessions support? Yes, it's not part of this series. I'll try bringing that as well. > >> Signed-off-by: Ekansh Gupta >> --- >> drivers/accel/qda/Makefile | 1 + >> drivers/accel/qda/qda_cb.c | 150 ++++++++++++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_cb.h | 26 ++++++++ >> drivers/accel/qda/qda_drv.h | 3 + >> drivers/accel/qda/qda_rpmsg.c | 40 +++++++++++ >> 5 files changed, 220 insertions(+) >> >> diff --git a/drivers/accel/qda/Makefile b/drivers/accel/qda/Makefile >> index 242684ef1af7..4aded20b6bc2 100644 >> --- a/drivers/accel/qda/Makefile >> +++ b/drivers/accel/qda/Makefile >> @@ -8,5 +8,6 @@ obj-$(CONFIG_DRM_ACCEL_QDA) := qda.o >> qda-y := \ >> qda_drv.o \ >> qda_rpmsg.o \ >> + qda_cb.o \ >> >> obj-$(CONFIG_DRM_ACCEL_QDA_COMPUTE_BUS) += qda_compute_bus.o >> diff --git a/drivers/accel/qda/qda_cb.c b/drivers/accel/qda/qda_cb.c >> new file mode 100644 >> index 000000000000..77a2d8cae076 >> --- /dev/null >> +++ b/drivers/accel/qda/qda_cb.c >> @@ -0,0 +1,150 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include "qda_drv.h" >> +#include "qda_cb.h" >> + >> +static void qda_cb_dev_release(struct device *dev) >> +{ >> + kfree(dev); > Do you need to put the reference on the OF node? Reference put is happening as part of qda_destroy_cb_device. > >> +} >> + >> +static int qda_configure_cb_iommu(struct device *cb_dev, struct device_node *cb_node) >> +{ >> + int ret; >> + >> + qda_dbg(NULL, "Configuring DMA/IOMMU for CB device %s\n", dev_name(cb_dev)); >> + >> + /* Use of_dma_configure which handles both DMA and IOMMU configuration */ >> + ret = of_dma_configure(cb_dev, cb_node, true); >> + if (ret) { >> + qda_err(NULL, "of_dma_configure failed for %s: %d\n", dev_name(cb_dev), ret); >> + return ret; >> + } >> + >> + qda_dbg(NULL, "DMA/IOMMU configured successfully for CB device %s\n", dev_name(cb_dev)); >> + return 0; >> +} >> + >> +static int qda_cb_setup_device(struct qda_dev *qdev, struct device *cb_dev) >> +{ >> + int rc; >> + u32 sid, pa_bits = 32; >> + >> + qda_dbg(qdev, "Setting up CB device %s\n", dev_name(cb_dev)); >> + >> + if (of_property_read_u32(cb_dev->of_node, "reg", &sid)) { >> + qda_dbg(qdev, "No 'reg' property found, defaulting SID to 0\n"); >> + sid = 0; > Don't do the job of the schema validator. Are there nodes without reg? > No. Ack. > >> + } >> + >> + rc = dma_set_mask(cb_dev, DMA_BIT_MASK(pa_bits)); >> + if (rc) { >> + qda_err(qdev, "%d bit DMA enable failed: %d\n", pa_bits, rc); >> + return rc; >> + } >> + >> + qda_dbg(qdev, "CB device setup complete - SID: %u, PA bits: %u\n", sid, pa_bits); >> + >> + return 0; >> +} >> + >> +int qda_create_cb_device(struct qda_dev *qdev, struct device_node *cb_node) >> +{ >> + struct device *cb_dev; >> + int ret; >> + u32 sid = 0; >> + struct qda_cb_dev *entry; >> + >> + qda_dbg(qdev, "Creating CB device for node: %s\n", cb_node->name); >> + >> + of_property_read_u32(cb_node, "reg", &sid); >> + >> + cb_dev = kzalloc_obj(*cb_dev, GFP_KERNEL); >> + if (!cb_dev) >> + return -ENOMEM; >> + >> + device_initialize(cb_dev); >> + cb_dev->parent = qdev->dev; >> + cb_dev->bus = &qda_cb_bus_type; /* Use our custom bus type for IOMMU handling */ >> + cb_dev->release = qda_cb_dev_release; >> + dev_set_name(cb_dev, "qda-cb-%s-%u", qdev->dsp_name, sid); >> + >> + qda_dbg(qdev, "Initialized CB device: %s\n", dev_name(cb_dev)); >> + >> + cb_dev->of_node = of_node_get(cb_node); >> + >> + cb_dev->dma_mask = &cb_dev->coherent_dma_mask; >> + cb_dev->coherent_dma_mask = DMA_BIT_MASK(32); >> + >> + dev_set_drvdata(cb_dev->parent, qdev); >> + >> + ret = device_add(cb_dev); >> + if (ret) { >> + qda_err(qdev, "Failed to add CB device for SID %u: %d\n", sid, ret); >> + goto cleanup_device_init; >> + } >> + >> + qda_dbg(qdev, "CB device added to system\n"); >> + >> + ret = qda_configure_cb_iommu(cb_dev, cb_node); >> + if (ret) { >> + qda_err(qdev, "IOMMU configuration failed: %d\n", ret); >> + goto cleanup_device_add; >> + } >> + >> + ret = qda_cb_setup_device(qdev, cb_dev); >> + if (ret) { >> + qda_err(qdev, "CB device setup failed: %d\n", ret); >> + goto cleanup_device_add; >> + } >> + >> + entry = kzalloc(sizeof(*entry), GFP_KERNEL); >> + if (!entry) { >> + ret = -ENOMEM; >> + goto cleanup_device_add; >> + } >> + >> + entry->dev = cb_dev; >> + list_add_tail(&entry->node, &qdev->cb_devs); >> + >> + qda_dbg(qdev, "Successfully created CB device for SID %u\n", sid); >> + return 0; >> + >> +cleanup_device_add: >> + device_del(cb_dev); >> +cleanup_device_init: >> + of_node_put(cb_dev->of_node); >> + put_device(cb_dev); >> + return ret; >> +} >> + >> +void qda_destroy_cb_device(struct device *cb_dev) >> +{ >> + struct iommu_group *group; >> + >> + if (!cb_dev) { >> + qda_dbg(NULL, "NULL CB device passed to destroy\n"); >> + return; >> + } >> + >> + qda_dbg(NULL, "Destroying CB device %s\n", dev_name(cb_dev)); >> + >> + group = iommu_group_get(cb_dev); >> + if (group) { >> + qda_dbg(NULL, "Removing %s from IOMMU group\n", dev_name(cb_dev)); >> + iommu_group_remove_device(cb_dev); >> + iommu_group_put(group); >> + } >> + >> + of_node_put(cb_dev->of_node); >> + cb_dev->of_node = NULL; >> + device_unregister(cb_dev); >> + >> + qda_dbg(NULL, "CB device %s destroyed\n", dev_name(cb_dev)); >> +} >> diff --git a/drivers/accel/qda/qda_cb.h b/drivers/accel/qda/qda_cb.h >> new file mode 100644 >> index 000000000000..a4ae9fef142e >> --- /dev/null >> +++ b/drivers/accel/qda/qda_cb.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#ifndef __QDA_CB_H__ >> +#define __QDA_CB_H__ >> + >> +#include >> +#include >> +#include >> +#include >> +#include "qda_drv.h" >> + >> +struct qda_cb_dev { >> + struct list_head node; >> + struct device *dev; >> +}; >> + >> +/* >> + * Compute bus (CB) device management >> + */ >> +int qda_create_cb_device(struct qda_dev *qdev, struct device_node *cb_node); >> +void qda_destroy_cb_device(struct device *cb_dev); >> + >> +#endif /* __QDA_CB_H__ */ >> diff --git a/drivers/accel/qda/qda_drv.h b/drivers/accel/qda/qda_drv.h >> index bec2d31ca1bb..eb732b7d8091 100644 >> --- a/drivers/accel/qda/qda_drv.h >> +++ b/drivers/accel/qda/qda_drv.h >> @@ -7,6 +7,7 @@ >> #define __QDA_DRV_H__ >> >> #include >> +#include >> #include >> #include >> #include >> @@ -26,6 +27,8 @@ struct qda_dev { >> atomic_t removing; >> /* Name of the DSP (e.g., "cdsp", "adsp") */ >> char dsp_name[16]; >> + /* Compute context-bank (CB) child devices */ >> + struct list_head cb_devs; >> }; >> >> /** >> diff --git a/drivers/accel/qda/qda_rpmsg.c b/drivers/accel/qda/qda_rpmsg.c >> index a8b24a99ca13..5a57384de6a2 100644 >> --- a/drivers/accel/qda/qda_rpmsg.c >> +++ b/drivers/accel/qda/qda_rpmsg.c >> @@ -7,6 +7,7 @@ >> #include >> #include "qda_drv.h" >> #include "qda_rpmsg.h" >> +#include "qda_cb.h" >> >> static int qda_rpmsg_init(struct qda_dev *qdev) >> { >> @@ -25,11 +26,42 @@ static struct qda_dev *alloc_and_init_qdev(struct rpmsg_device *rpdev) >> >> qdev->dev = &rpdev->dev; >> qdev->rpdev = rpdev; >> + INIT_LIST_HEAD(&qdev->cb_devs); >> >> qda_dbg(qdev, "Allocated and initialized qda_dev\n"); >> return qdev; >> } >> >> +static void qda_unpopulate_child_devices(struct qda_dev *qdev) >> +{ >> + struct qda_cb_dev *entry, *tmp; >> + >> + list_for_each_entry_safe(entry, tmp, &qdev->cb_devs, node) { >> + list_del(&entry->node); >> + qda_destroy_cb_device(entry->dev); >> + kfree(entry); > Why can't you embed struct device into a structure together with the > list_node (and possibly some other data?)? I'll check this. > >> + } >> +} >> + >> +static int qda_populate_child_devices(struct qda_dev *qdev, struct device_node *parent_node) >> +{ >> + struct device_node *child; >> + int count = 0, success = 0; >> + >> + for_each_child_of_node(parent_node, child) { >> + if (of_device_is_compatible(child, "qcom,fastrpc-compute-cb")) { >> + count++; >> + if (qda_create_cb_device(qdev, child) == 0) { >> + success++; >> + qda_dbg(qdev, "Created CB device for node: %s\n", child->name); >> + } else { >> + qda_err(qdev, "Failed to create CB device for: %s\n", child->name); > Don't loose the error code. Instead please return it to the caller. Ack. > >> + } >> + } >> + } >> + return success > 0 ? 0 : (count > 0 ? -ENODEV : 0); >> +} >> + >> static int qda_rpmsg_cb(struct rpmsg_device *rpdev, void *data, int len, void *priv, u32 src) >> { >> /* Dummy function for rpmsg driver */ >> @@ -48,6 +80,7 @@ static void qda_rpmsg_remove(struct rpmsg_device *rpdev) >> qdev->rpdev = NULL; >> mutex_unlock(&qdev->lock); >> >> + qda_unpopulate_child_devices(qdev); >> qda_deinit_device(qdev); >> >> qda_info(qdev, "RPMsg device removed\n"); >> @@ -83,6 +116,13 @@ static int qda_rpmsg_probe(struct rpmsg_device *rpdev) >> if (ret) >> return ret; >> >> + ret = qda_populate_child_devices(qdev, rpdev->dev.of_node); >> + if (ret) { >> + qda_err(qdev, "Failed to populate child devices: %d\n", ret); >> + qda_deinit_device(qdev); >> + return ret; >> + } >> + >> qda_info(qdev, "QDA RPMsg probe completed successfully for %s\n", qdev->dsp_name); >> return 0; >> } >> >> -- >> 2.34.1 >>