From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Alex Elder <elder@riscstar.com>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Lee Jones <lee@kernel.org>, Yixun Lan <dlan@gentoo.org>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C_K1
Date: Wed, 22 Oct 2025 12:40:23 +0800 [thread overview]
Message-ID: <579629FC3E61E9E6+aPhgN9kIRsEhuGE1@kernel.org> (raw)
In-Reply-To: <6DB8C5F20B3FAC2E+aPhfoRXlJtJymlB5@kernel.org>
On Wed, Oct 22, 2025 at 12:37:53PM +0800, Troy Mitchell wrote:
> On Tue, Oct 21, 2025 at 11:30:37PM -0500, Alex Elder wrote:
> > On 10/21/25 8:58 PM, Troy Mitchell wrote:
> > > select will force a symbol to a specific value without considering
> > > its dependencies. As a result, the i2c-k1 driver will fail to build
> > > when OF or COMMON_CLK are disabled.
> >
> > Should config I2C_K1 depend on COMMON_CLK then?
> Yes, this patch [1] registers the ILCR as a clock.
>
> >
> > But you're right, the selecting config should ensure the
> > dependencies of the selected one are satisfied.
> And the config REGULATOR_SPACEMIT_P1 select MFD_SPACEMIT_P1(RTC same).
> Should we change it to depends on?
Yixun has suggessted here[1] and I think too.
Link: https://lore.kernel.org/all/20251022004830-GYB1522542@gentoo.org/ [1]
prev parent reply other threads:[~2025-10-22 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 1:58 Troy Mitchell
2025-10-22 4:30 ` Alex Elder
2025-10-22 4:37 ` Troy Mitchell
2025-10-22 4:40 ` Troy Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579629FC3E61E9E6+aPhgN9kIRsEhuGE1@kernel.org \
--to=troy.mitchell@linux.spacemit.com \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®