From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756793AbcG0PW5 (ORCPT ); Wed, 27 Jul 2016 11:22:57 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:51921 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753296AbcG0PW4 (ORCPT ); Wed, 27 Jul 2016 11:22:56 -0400 Message-ID: <5798D1C9.3030806@osg.samsung.com> Date: Wed, 27 Jul 2016 16:22:49 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@ZenIV.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 1/4] fs: befs: Remove redundant validation from befs_find_brun_direct References: <9859a616787673d2f36ce21d4aa0220637c55001.1469588473.git.salah.triki@gmail.com> In-Reply-To: <9859a616787673d2f36ce21d4aa0220637c55001.1469588473.git.salah.triki@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/07/16 04:11, Salah Triki wrote: > The only caller of befs_find_brun_direct is befs_fblock2brun, which > already validates that the block is within the range of direct blocks. > So remove the duplicate validation. > > Signed-off-by: Salah Triki > Acked-by: Luis de Bethencourt > --- > fs/befs/datastream.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c > index 26cc417..e224b9a 100644 > --- a/fs/befs/datastream.c > +++ b/fs/befs/datastream.c > @@ -249,17 +249,9 @@ befs_find_brun_direct(struct super_block *sb, const befs_data_stream *data, > int i; > const befs_block_run *array = data->direct; > befs_blocknr_t sum; > - befs_blocknr_t max_block = > - data->max_direct_range >> BEFS_SB(sb)->block_shift; > > befs_debug(sb, "---> %s, find %lu", __func__, (unsigned long)blockno); > > - if (blockno > max_block) { > - befs_error(sb, "%s passed block outside of direct region", > - __func__); > - return BEFS_ERR; > - } > - > for (i = 0, sum = 0; i < BEFS_NUM_DIRECT_BLOCKS; > sum += array[i].len, i++) { > if (blockno >= sum && blockno < sum + (array[i].len)) { > Hi, I have applied 1, 2 and 3 from this series into: https://github.com/luisbg/linux-befs/tree/befs-next I had already tested and acked the 3 commits above. Having them in the above git branch [0] makes it easier to see the order of all recent commits. Andrew, I hope this process works for you. If not, let me know and I can adapt to however you prefer it to be. Thanks Salah :) Luis [0] reason for that git branch: https://lkml.org/lkml/2016/7/26/533