mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	"open list:SUSPEND TO RAM" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 3/7] PM: runtime: remove kernel-doc warnings
Date: Thu, 1 Apr 2021 09:13:18 -0500	[thread overview]
Message-ID: <579db6b4-d6ed-2dcb-b633-fe7fb94cb3c9@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0jS0Wfzq0M45ZbP2vNX4y=e+tvZjrmn4AiE+ycxij+CWg@mail.gmail.com>



On 4/1/21 8:40 AM, Rafael J. Wysocki wrote:
> On Thu, Apr 1, 2021 at 1:26 AM Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>>
>> remove make W=1 warnings
>>
>> drivers/base/power/runtime.c:926: warning: Function parameter or
>> member 'timer' not described in 'pm_suspend_timer_fn'
>>
>> drivers/base/power/runtime.c:926: warning: Excess function parameter
>> 'data' description in 'pm_suspend_timer_fn'
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> ---
>>   drivers/base/power/runtime.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
>> index fe1dad68aee4..1fc1a992f90c 100644
>> --- a/drivers/base/power/runtime.c
>> +++ b/drivers/base/power/runtime.c
>> @@ -951,7 +951,7 @@ static void pm_runtime_work(struct work_struct *work)
>>
>>   /**
>>    * pm_suspend_timer_fn - Timer function for pm_schedule_suspend().
>> - * @data: Device pointer passed by pm_schedule_suspend().
>> + * @timer: hrtimer used by pm_schedule_suspend().
>>    *
>>    * Check if the time is right and queue a suspend request.
>>    */
>> --
> 
> I can apply this along with the [4-5/7].  Do you want me to do that?

Works for me. I wasn't sure by looking at the MAINTAINERS file which 
files in drivers/base/ are maintained by whom, so sent the patches as a 
single set.

  reply	other threads:[~2021-04-01 18:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 23:26 [PATCH 0/7] drivers/base: " Pierre-Louis Bossart
2021-03-31 23:26 ` [PATCH 1/7] driver core: " Pierre-Louis Bossart
2021-03-31 23:26 ` [PATCH 2/7] driver core: attribute_container: " Pierre-Louis Bossart
2021-03-31 23:26 ` [PATCH 3/7] PM: runtime: " Pierre-Louis Bossart
2021-04-01 13:40   ` Rafael J. Wysocki
2021-04-01 14:13     ` Pierre-Louis Bossart [this message]
2021-04-02 14:24       ` Greg Kroah-Hartman
2021-04-07 17:23       ` Rafael J. Wysocki
2021-03-31 23:26 ` [PATCH 4/7] PM: wakeup: fix kernel-doc warnings and fix typos Pierre-Louis Bossart
2021-03-31 23:26 ` [PATCH 5/7] PM: clk: remove kernel-doc warning Pierre-Louis Bossart
2021-03-31 23:26 ` [PATCH 6/7] platform-msi: fix kernel-doc warnings Pierre-Louis Bossart
2021-03-31 23:26 ` [PATCH 7/7] devcoredump: fix kernel-doc warning Pierre-Louis Bossart
2021-04-01  7:07   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=579db6b4-d6ed-2dcb-b633-fe7fb94cb3c9@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome