From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbcHHVaW (ORCPT ); Mon, 8 Aug 2016 17:30:22 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:33032 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbcHHVaU (ORCPT ); Mon, 8 Aug 2016 17:30:20 -0400 Subject: Re: [PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear To: Krzysztof Kozlowski References: <1470448206-16538-1-git-send-email-shuahkh@osg.samsung.com> <20160808165657.GB5959@kozik-book> Cc: inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shuah Khan From: Shuah Khan Message-ID: <57A8F9E0.5000804@osg.samsung.com> Date: Mon, 8 Aug 2016 15:30:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160808165657.GB5959@kozik-book> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2016 10:56 AM, Krzysztof Kozlowski wrote: > On Fri, Aug 05, 2016 at 07:50:06PM -0600, Shuah Khan wrote: >> Fix unsupported GEM memory type error message to include the memory type >> information. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c >> index e016640..c9315df 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c >> @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev, >> flags = exynos_gem->flags; >> >> /* >> - * without iommu support, not support physically non-continuous memory >> + * without iommu support, not support physically non-contiguous memory > > While at it, how about changing entire sentence to something in English? :) Yes I can do that. Will send v2 :) > > Best regards, > Krzysztof > >> * for framebuffer. >> */ >> if (IS_NONCONTIG_BUFFER(flags)) { >> - DRM_ERROR("cannot use this gem memory type for fb.\n"); >> + DRM_ERROR("Non-continguous GEM memory is not supported.\n"); >> return -EINVAL; >> } >> >> -- >> 2.7.4 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel