From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbcHJEiH (ORCPT ); Wed, 10 Aug 2016 00:38:07 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:34164 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbcHJEiF (ORCPT ); Wed, 10 Aug 2016 00:38:05 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79286d000007a9a-15-57aaafab20fa Content-transfer-encoding: 8BIT Message-id: <57AAAFAA.8060200@samsung.com> Date: Wed, 10 Aug 2016 13:38:02 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de Cc: myungjoo.ham@samsung.com, mark.yao@rock-chips.com, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, kyungmin.park@samsung.com, linux-arm-kernel@lists.infradead.org, tixy@linaro.org, typ@rock-chips.com, sudeep.holla@arm.com, mark.rutland@arm.com, linux-pm@vger.kernel.org Subject: Re: [PATCH v5 6/8] Documentation: bindings: add dt documentation for rk3399 dmc References: <1470799604-12877-1-git-send-email-hl@rock-chips.com> <1470799604-12877-7-git-send-email-hl@rock-chips.com> In-reply-to: <1470799604-12877-7-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42JZI2JSqLt6/apwg+v7ZC16z51ksni1eQ+b xdllB9ksrnx9z2bx/9FrVosfG04xW5xtesNusenxNVaLy7vmsFl87j3CaPHpwX9mi6XXLzJZ 7JhygMni4ilXi9uNK9gsfpzpZrFYfmoHi8XC+ffZLWavrnMQ9lgzbw2jx/sbrewesxsusnhc 7utl8rhzbQ+bx/ZvD1g97ncfZ/LYvKTe4++s/SwefVtWMXpsvzaP2ePzJrkAnigum5TUnMyy 1CJ9uwSujFuLv7IUNIhWnFr3lLWB8YNAFyMnh4SAicTdpddZIWwxiQv31rN1MXJxCAmsYJRY /uEUI0zRzsbFUImljBK/L6xhB0nwCghK/Jh8j6WLkYODWUBe4silbJAws4C6xKR5i5gh6h8w SszZ2M4GUa8l8X5qIxOIzSKgKtFydyrYHDag+P4XN8Bq+AUUJa7+eMwIMlNUIEKi+0QlSFhE wEji7Jf5TCAzmQUOMEvM/9UP1issECVx4sRGJohlZxklZna+A0twCjhJLJ58FOxqCYE3HBLf D1xig9gsIPFt8iGwqyUEZCU2HWCG+FJS4uCKGywTGMVnIfltFsJvs5D8toCReRWjaGpBckFx UnqRoV5xYm5xaV66XnJ+7iZGYBo5/e9Z7w7G2wesDzEKcDAq8fB62K4KF2JNLCuuzD3EaAp0 xERmKdHkfGCyyiuJNzQ2M7IwNTE1NjK3NFMS51WU+hksJJCeWJKanZpakFoUX1Sak1p8iJGJ g1OqgTF78XPHvf1n/0lOv5UtffV7tdCPVI4Sj5r5397e+NqyJ1NHRHrjZa/lbw4pCCUaFL2r mFh++/e8js3aBypef2F+ZBQ2Pzz1y5OTDxji58u8P3RbK/jeivC2LWqhDru2pC3lYxf93r5t ZtqR+Ye8N6kfN+hO2Drn2ZHCZc8uRvjMZHFUVzO/8JlDiaU4I9FQi7moOBEAn4tZtR4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBKsWRmVeSWpSXmKPExsVy+t9jAd3V61eFG1xeLGrRe+4kk8WrzXvY LM4uO8hmceXrezaL/49es1r82HCK2eJs0xt2i02Pr7FaXN41h83ic+8RRotPD/4zWyy9fpHJ YseUA0wWF0+5WtxuXMFm8eNMN4vF8lM7WCwWzr/PbjF7dZ2DsMeaeWsYPd7faGX3mN1wkcXj cl8vk8eda3vYPLZ/e8Dqcb/7OJPH5iX1Hn9n7Wfx6NuyitFj+7V5zB6fN8kF8EQ1MNpkpCam pBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAP2opFCWmFMKFApI LC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcy4tfgrS0GDaMWpdU9ZGxg/CHQxcnJICJhI 7GxczAZhi0lcuLceyObiEBJYyijx+8IadpAEr4CgxI/J91i6GDk4mAXkJY5cygYJMwuoS0ya t4gZov4Bo8Scje1sEPVaEu+nNjKB2CwCqhItd6eCzWEDiu9/cQOshl9AUeLqj8eMIDNFBSIk uk9UgoRFBIwkzn6ZzwQyk1ngALPE/F/9YL3CAlESJ05sZIJYdpZRYmbnO7AEp4CTxOLJR9km MArOQnLrLIRbZyG5dQEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4FT1THoH4+Fd 7ocYBTgYlXh4d3CuChdiTSwrrsw9xCjBwawkwmu4CijEm5JYWZValB9fVJqTWnyI0RTo2YnM UqLJ+cA0mlcSb2hsYmZkaWRuaGFkbK4kzvv4/7owIYH0xJLU7NTUgtQimD4mDk6pBsZJZ04s aneVYXVnSzSdePJoj+zMeusTfbtWF4nv/mq7Y+3Ekppp/W46Mqec7d8v3dmhO+/DB/3t1Rpr vWdw+jwJ6XodsS41MnxvAte388U9omVTxJh/1HwR2xal9ydzCodca2nJ7qszP6dG1Id8fKBb 7uIo/O7xItcoj7cdTpuaM5+pqifcslFiKc5INNRiLipOBACOwH6qawMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lin, On 2016년 08월 10일 12:26, Lin Huang wrote: > This patch adds the documentation for rockchip rk3399 dmc driver. > > Signed-off-by: Lin Huang > --- > Changes in v5: > -None > > Changes in v4: > -None > > Changes in v3: > -None > > Changes in v2: > -None > > Changes in v1: > -None > > .../devicetree/bindings/devfreq/rk3399_dmc.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt > new file mode 100644 > index 0000000..90e9581 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt > @@ -0,0 +1,35 @@ > +* Rockchip rk3399 dmc device dmc -> DMC(Dynamic Memory Controller ?) > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dmc". > +- devfreq-events: Node to get ddr loading, Refer to > + Documentation/devicetree/bindings/devfreq/rockchip-dif.txt > +- interrupts: The interrupt number to the cpu. The interrupt specifier format > + depends on the interrupt controller. If you add the specific role of this interrupt, it would be better to understand the operation of interrupt. > +- clocks: Phandles for clock specified in "clock-names" property > +- clock-names : The name of clock used by the DFI, must be "pclk_ddr_mon"; "pclk_ddr_mon" -> "dmc_clk" > +- operating-points-v2: Refer to Documentation/devicetree/bindings/power/opp.txt > + for details. > +- center-supply: Dmc supply node. > +- status: Marks the node enabled/disabled. > + > +Optional properties: > +- ddr_timing: ddr timing need to pass to arm trust firmware > +- upthreshold: the upthreshold to simpleondeamnd policy > +- downdifferential: The downdifferential to simpleondeamnd policy > + > +Example: > + dmc: dmc { > + compatible = "rockchip,rk3399-dmc"; > + devfreq-events = <&dfi>; > + interrupts = ; > + clocks = <&cru SCLK_DDRCLK>; > + clock-names = "dmc_clk"; > + ddr_timing = <&ddr_timing>; I think that you should add the detailed document for 'ddr_timing' because we don't understand the 'ddr_timing' easily , it depends on the trust firmware. > + operating-points-v2 = <&dmc_opp_table>; I think that you better to add the example of 'dmc_opp_table' in the documentation. > + center-supply = <&ppvar_centerlogic>; > + upthreshold = <15>; > + downdifferential = <10>; > + status = "disabled"; > + }; > + > Regards, Chanwoo Choi