From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755522AbcHSPQa convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 19 Aug 2016 11:16:30 -0400
Received: from prv-mh.provo.novell.com ([137.65.248.74]:46840 "EHLO
        prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754146AbcHSPPq (ORCPT
        <rfc822;groupwise-linux-kernel@vger.kernel.org:6:1>);
        Fri, 19 Aug 2016 11:15:46 -0400
Message-Id: <57B73E6F02000078001077D1@prv-mh.provo.novell.com>
X-Mailer: Novell GroupWise Internet Agent 14.2.1 
Date: Fri, 19 Aug 2016 09:14:23 -0600
From: "Jan Beulich" <JBeulich@suse.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Cc: <stefan.bader@canonical.com>, <david.vrabel@citrix.com>,
        "xen-devel" <xen-devel@lists.xenproject.org>,
        "Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
        <chuck.anderson@oracle.com>, "Juergen Gross" <JGross@suse.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: XSA 154 and ISA region (640K -> 1MB) WB cache instead of
 UC
References: <20160817203238.GA9408@char.us.oracle.com>
 <57B5A4C90200007800106FF2@prv-mh.provo.novell.com>
 <20160819145200.GB26577@char.us.oracle.com>
In-Reply-To: <20160819145200.GB26577@char.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> On 19.08.16 at 16:52, <konrad.wilk@oracle.com> wrote:
> On Thu, Aug 18, 2016 at 04:06:33AM -0600, Jan Beulich wrote:
>> >>> On 17.08.16 at 22:32, <konrad.wilk@oracle.com> wrote:
>> >    Looking at the kernel it assumes that WB is ok for 640KB->1MB.
>> >    The comment says:
>> >    " /* Low ISA region is always mapped WB in page table. No need to track *"
>> 
>> As per above it's not clear to me what this comment is backed by.
> 
> I was hoping you would know :-)
> 
> Ah, commit 2e5d9c857d4e6c9e7b7d8c8c86a68a7842d213d6
> Author: venkatesh.pallipadi@intel.com <venkatesh.pallipadi@intel.com>
> Date:   Tue Mar 18 17:00:14 2008 -0700
> 
>     x86: PAT infrastructure patch
>     
>     Sets up pat_init() infrastructure.
>     
> 
> which sets the MTRR for that region.

Hmm, that's the commit which introduced pat.c years ago. I can't
see it writing an MTRRs though, nor can I see it backing the comment
in adds in any way. I guess I'm confused...

Jan