From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336AbcICMnI (ORCPT ); Sat, 3 Sep 2016 08:43:08 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:20045 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754166AbcICMnB (ORCPT ); Sat, 3 Sep 2016 08:43:01 -0400 Message-ID: <57CAC551.7040505@bfs.de> Date: Sat, 03 Sep 2016 14:42:57 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: SF Markus Elfring CC: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky , LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini Subject: Re: [PATCH 09/17] s390/debug: Return directly if a null pointer was passed to debug_unregister() References: <566ABCD9.1060404@users.sourceforge.net> <9c7f85c9-75db-99fb-88ce-b3e6f01b69db@users.sourceforge.net> In-Reply-To: <9c7f85c9-75db-99fb-88ce-b3e6f01b69db@users.sourceforge.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 03.09.2016 14:24, schrieb SF Markus Elfring: > From: Markus Elfring > Date: Thu, 1 Sep 2016 19:34:45 +0200 > > Return directly at the beginning if a null pointer was passed for > the input parameter of this function. > > Signed-off-by: Markus Elfring > --- > arch/s390/kernel/debug.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c > index c4a4641..d137150 100644 > --- a/arch/s390/kernel/debug.c > +++ b/arch/s390/kernel/debug.c > @@ -736,13 +736,10 @@ void > debug_unregister(debug_info_t * id) > { > if (!id) > - goto out; > + return; > mutex_lock(&debug_mutex); > debug_info_put(id); > mutex_unlock(&debug_mutex); > - > -out: > - return; > } > EXPORT_SYMBOL(debug_unregister); > debug_info_put() will check for NULL, the whole check can be removed. re, wh