From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982AbcIEGnF (ORCPT ); Mon, 5 Sep 2016 02:43:05 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:48353 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754719AbcIEGnD (ORCPT ); Mon, 5 Sep 2016 02:43:03 -0400 X-Auth-Info: x90QZegQ5rqCw6QA4YL7MNNUcMwnZZElatGZVRZNmKk= Subject: Re: [PATCH] ubifs: compress lines for immediate return To: Richard Weinberger References: <1473051597-30078-1-git-send-email-hs@denx.de> <94271caf-4852-1d08-c6a0-102aac22ab65@nod.at> Cc: linux-mtd@lists.infradead.org, Artem Bityutskiy , Adrian Hunter , Masahiro Yamada , linux-kernel@vger.kernel.org Reply-To: hs@denx.de From: Heiko Schocher Message-ID: <57CD1239.6060105@denx.de> Date: Mon, 5 Sep 2016 08:35:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <94271caf-4852-1d08-c6a0-102aac22ab65@nod.at> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Richard, Am 05.09.2016 um 08:28 schrieb Richard Weinberger: > Heiko, > > On 05.09.2016 06:59, Heiko Schocher wrote: >> fix the following code: >> >> -ret = expression; >> -if (ret) >> - return ret; >> -return 0; >> +return expression; > > "Fix"? ;-) > What was broken? Ok, fix is to hard spoken ... nothing broken, sorry for confusing! > I agree that we can write the expression in a different way, but is it really worth it? I think yes ... > Is this part of a tree-wide cleanup? Yes, and I thought it is worth to change this part in linux too. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany