From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753861AbcIJC7p (ORCPT ); Fri, 9 Sep 2016 22:59:45 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:48018 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753376AbcIJC7n (ORCPT ); Fri, 9 Sep 2016 22:59:43 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED4: 1 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: xie.baoyou@zte.com.cn X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <1b82b31ea38ca9f9e138e139516bd4e6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: mark symbols static where possible To: Baoyou Xie , airlied@linux.ie, heiko@sntech.de References: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Mark yao Message-ID: <57D37716.5000902@rock-chips.com> Date: Sat, 10 Sep 2016 10:59:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年09月07日 19:01, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:318:6: warning: no previous prototype for 'rockchip_drm_fb_resume' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to my drm-fixes, Thanks > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index a822d49..3723683 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -306,7 +306,7 @@ static struct drm_driver rockchip_drm_driver = { > }; > > #ifdef CONFIG_PM_SLEEP > -void rockchip_drm_fb_suspend(struct drm_device *drm) > +static void rockchip_drm_fb_suspend(struct drm_device *drm) > { > struct rockchip_drm_private *priv = drm->dev_private; > > @@ -315,7 +315,7 @@ void rockchip_drm_fb_suspend(struct drm_device *drm) > console_unlock(); > } > > -void rockchip_drm_fb_resume(struct drm_device *drm) > +static void rockchip_drm_fb_resume(struct drm_device *drm) > { > struct rockchip_drm_private *priv = drm->dev_private; > -- Ｍark Yao 姚智情 Rockchip 福州瑞芯微电子有限公司 Fuzhou Headquarters Addr:No.21 Building, A District, Fuzhou Software Park, 89 Soft Avenue, Tongpan Road, Gulou District, Fuzhou (350003) 地址:福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003) Tel:（86-0591）83991906 - 8296 E-mail:mark.yao@rock-chips.com