From: Kishon Vijay Abraham I <kishon@ti.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
<linux-kernel@vger.kernel.org>, "arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH] phy: sun4i-usb: Fix build dependency
Date: Fri, 16 Sep 2016 14:07:05 +0530 [thread overview]
Message-ID: <57DBAF31.4030604@ti.com> (raw)
In-Reply-To: <1473992148-8860-1-git-send-email-axel.lin@ingics.com>
+Arnd
Hi,
On Friday 16 September 2016 07:45 AM, Axel Lin wrote:
> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
> build error.
>
> ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
Arnd was trying to solve the same issue.
Thanks
Kishon
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/phy/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index cc27c12..b65aba0 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -258,6 +258,8 @@ config PHY_SUN4I_USB
> depends on RESET_CONTROLLER
> depends on EXTCON
> depends on POWER_SUPPLY
> + depends on USB_SUPPORT
> + select USB_COMMON
> select GENERIC_PHY
> help
> Enable this to support the transceiver that is part of Allwinner
>
prev parent reply other threads:[~2016-09-16 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 2:15 Axel Lin
2016-09-16 8:37 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DBAF31.4030604@ti.com \
--to=kishon@ti.com \
--cc=arnd@arndb.de \
--cc=axel.lin@ingics.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®