From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934202AbcISIwE (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 04:52:04 -0400
Received: from foss.arm.com ([217.140.101.70]:56126 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754476AbcISIuS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 04:50:18 -0400
Subject: Re: [PATCH] pinctrl: nomadik: don't default-flag IRQs as falling
To: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <1474273330-15789-1-git-send-email-linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <57DFA6B8.5070306@arm.com>
Date: Mon, 19 Sep 2016 09:50:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.7.0
MIME-Version: 1.0
In-Reply-To: <1474273330-15789-1-git-send-email-linus.walleij@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/09/16 09:22, Linus Walleij wrote:
> There is no point in adding any default trigger for these
> GPIO interrupts: the device tree should contain all trigger
> information and the platforms using the driver boots
> exclusively from device tree.
> 
> Also the boot log is nagging me to fix this:
> 
> [    0.771057] ------------[ cut here ]------------
> [    0.775695] WARNING: CPU: 0 PID: 1 at
>    ../drivers/gpio/gpiolib.c:1622 _gpiochip_irqchip_add+0x138/0x160
> [    0.785034] /soc/gpio@8012e000: Ignoring 2 default trigger
> (...)
> [    0.942962] gpio 8012e000.gpio: at address e08f8000
> (etc ad nauseam)
> 
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index 205fb399268a..d318ca055489 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -1177,7 +1177,7 @@ static int nmk_gpio_probe(struct platform_device *dev)
>  				   irqchip,
>  				   0,
>  				   handle_edge_irq,
> -				   IRQ_TYPE_EDGE_FALLING);
> +				   IRQ_TYPE_NONE);
>  	if (ret) {
>  		dev_err(&dev->dev, "could not add irqchip\n");
>  		gpiochip_remove(&nmk_chip->chip);
> 

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...