From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbcJCQaa (ORCPT ); Mon, 3 Oct 2016 12:30:30 -0400 Received: from smtp02.mail.online.nl ([194.134.25.72]:17643 "EHLO smtp02.mail.online.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252AbcJCQaZ (ORCPT ); Mon, 3 Oct 2016 12:30:25 -0400 Subject: Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode To: Andrew Lunn References: <1475499870-11465-1-git-send-email-mike.looijmans@topic.nl> <20161003143508.GA26382@lunn.ch> Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com From: Mike Looijmans Organization: Topic Message-ID: <57F28799.7030701@topic.nl> Date: Mon, 3 Oct 2016 18:30:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20161003143508.GA26382@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-10-16 16:35, Andrew Lunn wrote: >> + Boolean: >> + >> + - enable-edpd : Not related to timing. Specify this property to enable >> + energy-detect power-down mode in the PHY. > > The Broadcom PHYs unconditionally enable this feature. > > The SMSC driver has an option: smsc,disable-energy-detect because it > seems to have a rare hardware bug when it is enabled. > > And you would like to make it off by default. > > Could we avoid having three drivers doing three different things? > Could you have it unconditionally on, and see if anybody reports it > being broken? Good suggestion I think. It's a feature found on many PHYs, apparently without any ill effects, so just enabling unconditionally simplifies things. And it's good for the environment... I'll post a v2 patch (which won't need devicetree changes then). -- Mike Looijmans