From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932700AbcJLJZ1 (ORCPT ); Wed, 12 Oct 2016 05:25:27 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33040 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932426AbcJLJZV (ORCPT ); Wed, 12 Oct 2016 05:25:21 -0400 Date: Wed, 12 Oct 2016 11:25:18 +0200 From: Michal Hocko To: zijun_hu Cc: Andrew Morton , rientjes@google.com, tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com, mgorman@techsingularity.net, sfr@canb.auug.org.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zijun_hu@htc.com Subject: Re: [RESEND RFC PATCH v2 1/1] mm/vmalloc.c: simplify /proc/vmallocinfo implementation Message-ID: <20161012092518.GG17128@dhcp22.suse.cz> References: <57FDF2E5.1000201@zoho.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57FDF2E5.1000201@zoho.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 12-10-16 16:23:01, zijun_hu wrote: > From: zijun_hu > > many seq_file helpers exist for simplifying implementation of virtual files > especially, for /proc nodes. however, the helpers for iteration over > list_head are available but aren't adopted to implement /proc/vmallocinfo > currently. > > simplify /proc/vmallocinfo implementation by existing seq_file helpers the simplification is nice and code duplication removal useful > Signed-off-by: zijun_hu Acked-by: Michal Hocko Thanks! > --- > Changes in v2: > - the redundant type cast is removed as advised by rientjes@google.com > - commit messages are updated > > mm/vmalloc.c | 27 +++++---------------------- > 1 file changed, 5 insertions(+), 22 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index f2481cb4e6b2..e73948afac70 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2574,32 +2574,13 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) > static void *s_start(struct seq_file *m, loff_t *pos) > __acquires(&vmap_area_lock) > { > - loff_t n = *pos; > - struct vmap_area *va; > - > spin_lock(&vmap_area_lock); > - va = list_first_entry(&vmap_area_list, typeof(*va), list); > - while (n > 0 && &va->list != &vmap_area_list) { > - n--; > - va = list_next_entry(va, list); > - } > - if (!n && &va->list != &vmap_area_list) > - return va; > - > - return NULL; > - > + return seq_list_start(&vmap_area_list, *pos); > } > > static void *s_next(struct seq_file *m, void *p, loff_t *pos) > { > - struct vmap_area *va = p, *next; > - > - ++*pos; > - next = list_next_entry(va, list); > - if (&next->list != &vmap_area_list) > - return next; > - > - return NULL; > + return seq_list_next(p, &vmap_area_list, pos); > } > > static void s_stop(struct seq_file *m, void *p) > @@ -2634,9 +2615,11 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v) > > static int s_show(struct seq_file *m, void *p) > { > - struct vmap_area *va = p; > + struct vmap_area *va; > struct vm_struct *v; > > + va = list_entry(p, struct vmap_area, list); > + > /* > * s_show can encounter race with remove_vm_area, !VM_VM_AREA on > * behalf of vmap area is being tear down or vm_map_ram allocation. > -- > 1.9.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754481AbcJLKNr (ORCPT ); Wed, 12 Oct 2016 06:13:47 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:25365 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932680AbcJLKNh (ORCPT ); Wed, 12 Oct 2016 06:13:37 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=cc:from:subject:to:message-id:date:user-agent:mime-version:content-type; b=rXQc+LTTC7D5syikUI50ohlKZtKpCsdnVXB1K8IuyeQGodWLxf3Bqwi/3UxHL+hlS0AtcI1GmJ5r N2tdf8wkn3l+Lr8etfRwE5/d2yosURbE9A6GSJVMeppPO0z9blQf Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zijun_hu@htc.com From: zijun_hu Subject: [RESEND RFC PATCH v2 1/1] mm/vmalloc.c: simplify /proc/vmallocinfo implementation To: Andrew Morton , rientjes@google.com, tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com, mgorman@techsingularity.net, mhocko@kernel.org, sfr@canb.auug.org.au Message-ID: <57FDF2E5.1000201@zoho.com> Date: Wed, 12 Oct 2016 16:23:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zijun_hu many seq_file helpers exist for simplifying implementation of virtual files especially, for /proc nodes. however, the helpers for iteration over list_head are available but aren't adopted to implement /proc/vmallocinfo currently. simplify /proc/vmallocinfo implementation by existing seq_file helpers Signed-off-by: zijun_hu --- Changes in v2: - the redundant type cast is removed as advised by rientjes@google.com - commit messages are updated mm/vmalloc.c | 27 +++++---------------------- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index f2481cb4e6b2..e73948afac70 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2574,32 +2574,13 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) static void *s_start(struct seq_file *m, loff_t *pos) __acquires(&vmap_area_lock) { - loff_t n = *pos; - struct vmap_area *va; - spin_lock(&vmap_area_lock); - va = list_first_entry(&vmap_area_list, typeof(*va), list); - while (n > 0 && &va->list != &vmap_area_list) { - n--; - va = list_next_entry(va, list); - } - if (!n && &va->list != &vmap_area_list) - return va; - - return NULL; - + return seq_list_start(&vmap_area_list, *pos); } static void *s_next(struct seq_file *m, void *p, loff_t *pos) { - struct vmap_area *va = p, *next; - - ++*pos; - next = list_next_entry(va, list); - if (&next->list != &vmap_area_list) - return next; - - return NULL; + return seq_list_next(p, &vmap_area_list, pos); } static void s_stop(struct seq_file *m, void *p) @@ -2634,9 +2615,11 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v) static int s_show(struct seq_file *m, void *p) { - struct vmap_area *va = p; + struct vmap_area *va; struct vm_struct *v; + va = list_entry(p, struct vmap_area, list); + /* * s_show can encounter race with remove_vm_area, !VM_VM_AREA on * behalf of vmap area is being tear down or vm_map_ram allocation. -- 1.9.1